Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: README.chromium

Issue 256183002: Fix two more compile errros on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | patches/vscomp.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.chromium
===================================================================
--- README.chromium (revision 266602)
+++ README.chromium (working copy)
@@ -142,6 +142,12 @@
- patches/vscomp.patch for building with Visual Studio on Windows.
a. do not use WINDOWS_LOCALE_API in locmap.c
b. do not redefine stringpiece::npos
+ c. fix a Windows build failure with U_USING_ICU_NAMESPACE=0
+ upstream bug: http://bugs.icu-project.org/trac/ticket/10486
+ fixed in ICU 53)
+ d. Explicitly use Windows 'A' API when argument is an LPSTR in wintz.c
+ upstream bug : http://bugs.icu-project.org/trac/ticket/10870
+
- patches/data.build.patch :
Remove unnecessary resources : invuca, unames, collator source, stringprep
- patches/data.build.win.patch :
@@ -211,3 +217,4 @@
10. Change export of U_ICUDATA_ENTRY_POINT from U_IMPORT to U_EXPORT.
- patches/declspec.patch
+
Mark Mentovai 2014/04/29 13:07:43 Introduced an unnecessary blank line here.
« no previous file with comments | « no previous file | patches/vscomp.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698