Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: README.chromium

Issue 256183002: Fix two more compile errros on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | patches/vscomp.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: icu 1 Name: icu
2 URL: http://site.icu-project.org/ 2 URL: http://site.icu-project.org/
3 Version: 52.1 3 Version: 52.1
4 License: MIT 4 License: MIT
5 Security Critical: yes 5 Security Critical: yes
6 6
7 Description: 7 Description:
8 This directory contains the source code of ICU 52.1 for C/C++ 8 This directory contains the source code of ICU 52.1 for C/C++
9 9
10 1. It was obtained with the following: 10 1. It was obtained with the following:
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 TRANSLIT_SOURCE=css3transform.txt 135 TRANSLIT_SOURCE=css3transform.txt
136 136
137 8. Build-related changes 137 8. Build-related changes
138 138
139 - patches/wpo.patch 139 - patches/wpo.patch
140 Upstream bugs : http://bugs.icu-project.org/trac/ticket/8043 140 Upstream bugs : http://bugs.icu-project.org/trac/ticket/8043
141 http://bugs.icu-project.org/trac/ticket/5701 141 http://bugs.icu-project.org/trac/ticket/5701
142 - patches/vscomp.patch for building with Visual Studio on Windows. 142 - patches/vscomp.patch for building with Visual Studio on Windows.
143 a. do not use WINDOWS_LOCALE_API in locmap.c 143 a. do not use WINDOWS_LOCALE_API in locmap.c
144 b. do not redefine stringpiece::npos 144 b. do not redefine stringpiece::npos
145 c. fix a Windows build failure with U_USING_ICU_NAMESPACE=0
146 upstream bug: http://bugs.icu-project.org/trac/ticket/10486
147 fixed in ICU 53)
148 d. Explicitly use Windows 'A' API when argument is an LPSTR in wintz.c
149 upstream bug : http://bugs.icu-project.org/trac/ticket/10870
150
145 - patches/data.build.patch : 151 - patches/data.build.patch :
146 Remove unnecessary resources : invuca, unames, collator source, stringprep 152 Remove unnecessary resources : invuca, unames, collator source, stringprep
147 - patches/data.build.win.patch : 153 - patches/data.build.win.patch :
148 Windows-only data build patch. 154 Windows-only data build patch.
149 155
150 9. Pre-built data files are checked in with the following steps on Linux: 156 9. Pre-built data files are checked in with the following steps on Linux:
151 157
152 a. Make a icu data build directory outside the Chromium source tree 158 a. Make a icu data build directory outside the Chromium source tree
153 and cd to that directory. 159 and cd to that directory.
154 b. Run 160 b. Run
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 c. In Visual Studio, open source/allinone/allinone.sln solution 210 c. In Visual Studio, open source/allinone/allinone.sln solution
205 in ${SEPARATE_ICU_ROOT} 211 in ${SEPARATE_ICU_ROOT}
206 d. Build 'makedata' target 212 d. Build 'makedata' target
207 e. icudt52.dll will be generated in ${SEPARATE_ICU_ROOT}/bin 213 e. icudt52.dll will be generated in ${SEPARATE_ICU_ROOT}/bin
208 f. Copy that icudt52.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll 214 f. Copy that icudt52.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll
209 and check that in. 215 and check that in.
210 216
211 217
212 10. Change export of U_ICUDATA_ENTRY_POINT from U_IMPORT to U_EXPORT. 218 10. Change export of U_ICUDATA_ENTRY_POINT from U_IMPORT to U_EXPORT.
213 - patches/declspec.patch 219 - patches/declspec.patch
220
Mark Mentovai 2014/04/29 13:07:43 Introduced an unnecessary blank line here.
OLDNEW
« no previous file with comments | « no previous file | patches/vscomp.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698