Issue 256183002: Fix two more compile errros on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256183002: Fix two more compile errros on Windows. (Closed)

Created:
6 years, 7 months ago by jungshik at Google

Modified:
6 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Visibility:
Public.

More Reviews

Description

Fix two more compile errros on Windows. umutex.h and wintz.c have two compile errors on Windows. The former issue was fixed in the upstream, but the latter is not. I reported the latter to the upstream (see README.chromium) BUG=132145 TEST=Can build on Windows with icu52. R=mark@chromium.org TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266901

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -2 lines)			Patch
M	README.chromium	View	2 chunks	+7 lines, -0 lines	1 comment	Download
M	patches/vscomp.patch	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	source/common/umutex.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/common/wintz.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/256183002/diff/1/README.chromium File README.chromium (right): https://codereview.chromium.org/256183002/diff/1/README.chromium#newcode220 README.chromium:220: Introduced an unnecessary blank line here.

6 years, 7 months ago (2014-04-29 13:07:43 UTC) #2

jungshik at Google

Committed patchset #1 manually as r266901 (presubmit successful).

6 years, 7 months ago (2014-04-29 16:53:03 UTC) #3

jungshik at Google

6 years, 7 months ago (2014-04-29 16:53:38 UTC) #4

Message was sent while issue was closed.

On 2014/04/29 13:07:43, Mark Mentovai wrote:
> LGTM
> 
> https://codereview.chromium.org/256183002/diff/1/README.chromium
> File README.chromium (right):
> 
> https://codereview.chromium.org/256183002/diff/1/README.chromium#newcode220
> README.chromium:220: 
> Introduced an unnecessary blank line here.

Thanks. Got rid of it and just committed.

Expand Messages | Collapse Messages