Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2561773002: Revert of Merged: [cpu-profiler] use new source position information for deoptimization in cpu profiler (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
Reviewers:
alph, Tobias Tebbi
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Revert of Merged: [cpu-profiler] use new source position information for deoptimization in cpu profiler (patchset #2 id:20001 of https://codereview.chromium.org/2559743002/ ) Reason for revert: The reason for reverting is: The corresponding tests fail because we did not merge https://codereview.chromium.org/2504913003/ before.. Original issue's description: > Merged: [cpu-profiler] use new source position information for deoptimization in cpu profiler > > Revision: 1b320d2039f961f8271a0b3e2a06abaf7bf0c3f0 > > BUG=v8:5432 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=alph@chromium.org TBR=alph@chromium.org,tebbi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -137 lines) Patch
M src/compilation-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/profiler/cpu-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/profiler/cpu-profiler-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/profile-generator.h View 4 chunks +15 lines, -4 lines 0 comments Download
M src/profiler/profile-generator.cc View 3 chunks +22 lines, -8 lines 0 comments Download
M src/profiler/profile-generator-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/profiler/profiler-listener.cc View 4 chunks +59 lines, -33 lines 0 comments Download
M src/source-position.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/source-position.cc View 3 chunks +41 lines, -35 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 7 chunks +31 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Michael Hablich
4 years ago (2016-12-08 10:06:09 UTC) #2
Created Revert of Merged: [cpu-profiler] use new source position information for
deoptimization in cpu profiler

Powered by Google App Engine
This is Rietveld 408576698