Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2559743002: Merged: [cpu-profiler] use new source position information for deoptimization in cpu profiler (Closed)

Created:
4 years ago by Tobias Tebbi
Modified:
4 years ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: [cpu-profiler] use new source position information for deoptimization in cpu profiler Revision: 1b320d2039f961f8271a0b3e2a06abaf7bf0c3f0 BUG=v8:5432 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=alph@chromium.org Review-Url: https://codereview.chromium.org/2559743002

Patch Set 1 #

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -179 lines) Patch
M src/compilation-info.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/profiler/cpu-profiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/profiler/cpu-profiler-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/profile-generator.h View 4 chunks +4 lines, -15 lines 0 comments Download
M src/profiler/profile-generator.cc View 3 chunks +8 lines, -22 lines 0 comments Download
M src/profiler/profile-generator-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/profiler/profiler-listener.cc View 4 chunks +33 lines, -59 lines 0 comments Download
M src/source-position.h View 2 chunks +4 lines, -7 lines 0 comments Download
M src/source-position.cc View 3 chunks +35 lines, -41 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 7 chunks +29 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Tobias Tebbi
4 years ago (2016-12-07 16:10:25 UTC) #1
Tobias Tebbi
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years ago (2016-12-07 16:10:26 UTC) #2
Tobias Tebbi
Hi Alexei, Sorry, somehow the last CL had messed up metadata. Trying again...
4 years ago (2016-12-07 16:15:38 UTC) #3
alph
lgtm
4 years ago (2016-12-07 17:38:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559743002/20001
4 years ago (2016-12-07 17:44:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 17:45:04 UTC) #8
Tobias Tebbi
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2551143006/ by tebbi@chromium.org. ...
4 years ago (2016-12-07 18:56:50 UTC) #9
Michael Hablich
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2561773002/ by hablich@chromium.org. ...
4 years ago (2016-12-08 10:06:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559743002/20001
4 years ago (2016-12-09 13:58:13 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 13:58:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698