Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2561743002: Generate traps for unhandled statement nodes (Closed)

Created:
4 years ago by sra1
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Generate traps for unhandled statement nodes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +11 lines, -1 line 1 comment Download

Messages

Total messages: 7 (4 generated)
sra1
4 years ago (2016-12-08 03:45:53 UTC) #3
sra1
Committed patchset #2 (id:20001) manually as d7b2670e58ed2cc501789f1083c8edd5e1b68581 (presubmit successful).
4 years ago (2016-12-08 04:09:33 UTC) #5
Siggi Cherem (dart-lang)
4 years ago (2016-12-08 05:30:07 UTC) #7
Message was sent while issue was closed. 
lgtm!

https://codereview.chromium.org/2561743002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2561743002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:6: import
'package:kernel/text/ast_to_text.dart' show debugNodeToString;
delete? (unused?)

Powered by Google App Engine
This is Rietveld 408576698