Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2561743002: Generate traps for unhandled statement nodes (Closed)
Patch Set: Generate traps for unhandled statement nodes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 4fa9c303a418b45c84426d5236cff5976f2f4270..7c03f8f1b5fa4c0f45048887de0f89f420798421 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
import 'package:kernel/ast.dart' as ir;
+import 'package:kernel/text/ast_to_text.dart' show debugNodeToString;
Siggi Cherem (dart-lang) 2016/12/08 05:30:06 delete? (unused?)
import '../closure.dart';
import '../common.dart';
@@ -432,7 +433,16 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
@override
void defaultExpression(ir.Expression expression) {
// TODO(het): This is only to get tests working.
- String message = 'Unhandled ir.${expression.runtimeType} $expression';
+ _trap('Unhandled ir.${expression.runtimeType} $expression');
+ }
+
+ @override
+ void defaultStatement(ir.Statement statement) {
+ _trap('Unhandled ir.${statement.runtimeType} $statement');
+ pop();
+ }
+
+ void _trap(String message) {
HInstruction nullValue = graph.addConstantNull(compiler);
HInstruction errorMessage =
graph.addConstantString(new DartString.literal(message), compiler);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698