Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2561693002: Move sticky position constraints update to the pre-paint tree walk. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 8a2ceafec70d524fec4f83601f7ab4216ebe48f3..e8f9f17d304d3d913d9e531bf6734256bee6b9fa 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -1036,11 +1036,16 @@ PaintLayer* PaintLayer::enclosingLayerForPaintInvalidation() const {
void PaintLayer::setNeedsCompositingInputsUpdate() {
setNeedsCompositingInputsUpdateInternal();
- // TODO(chrishtr): This is a bit of a heavy hammer, because not all
+ // TODO(chrishtr): These are a bit of a heavy hammer, because not all
// things which require compositing inputs update require a descendant-
// dependent flags udpate. Reduce call sites after SPv2 launch allows
/// removal of CompositingInputsUpdater.
markAncestorChainForDescendantDependentFlagsUpdate();
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+ // This update is needed in order to re-compute sticky position constraints,
+ // not for any other reason.
+ layoutObject()->setNeedsPaintPropertyUpdate();
+ }
}
void PaintLayer::setNeedsCompositingInputsUpdateInternal() {

Powered by Google App Engine
This is Rietveld 408576698