Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2561693002: Move sticky position constraints update to the pre-paint tree walk. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 1018 matching lines...) Expand 10 before | Expand all | Expand 10 after
1029 if (curr->isPaintInvalidationContainer()) 1029 if (curr->isPaintInvalidationContainer())
1030 return curr; 1030 return curr;
1031 } 1031 }
1032 1032
1033 return nullptr; 1033 return nullptr;
1034 } 1034 }
1035 1035
1036 void PaintLayer::setNeedsCompositingInputsUpdate() { 1036 void PaintLayer::setNeedsCompositingInputsUpdate() {
1037 setNeedsCompositingInputsUpdateInternal(); 1037 setNeedsCompositingInputsUpdateInternal();
1038 1038
1039 // TODO(chrishtr): This is a bit of a heavy hammer, because not all 1039 // TODO(chrishtr): These are a bit of a heavy hammer, because not all
1040 // things which require compositing inputs update require a descendant- 1040 // things which require compositing inputs update require a descendant-
1041 // dependent flags udpate. Reduce call sites after SPv2 launch allows 1041 // dependent flags udpate. Reduce call sites after SPv2 launch allows
1042 /// removal of CompositingInputsUpdater. 1042 /// removal of CompositingInputsUpdater.
1043 markAncestorChainForDescendantDependentFlagsUpdate(); 1043 markAncestorChainForDescendantDependentFlagsUpdate();
1044 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
1045 // This update is needed in order to re-compute sticky position constraints,
1046 // not for any other reason.
1047 layoutObject()->setNeedsPaintPropertyUpdate();
1048 }
1044 } 1049 }
1045 1050
1046 void PaintLayer::setNeedsCompositingInputsUpdateInternal() { 1051 void PaintLayer::setNeedsCompositingInputsUpdateInternal() {
1047 m_needsAncestorDependentCompositingInputsUpdate = true; 1052 m_needsAncestorDependentCompositingInputsUpdate = true;
1048 1053
1049 for (PaintLayer* current = this; 1054 for (PaintLayer* current = this;
1050 current && !current->m_childNeedsCompositingInputsUpdate; 1055 current && !current->m_childNeedsCompositingInputsUpdate;
1051 current = current->parent()) 1056 current = current->parent())
1052 current->m_childNeedsCompositingInputsUpdate = true; 1057 current->m_childNeedsCompositingInputsUpdate = true;
1053 1058
(...skipping 2223 matching lines...) Expand 10 before | Expand all | Expand 10 after
3277 } 3282 }
3278 3283
3279 void showLayerTree(const blink::LayoutObject* layoutObject) { 3284 void showLayerTree(const blink::LayoutObject* layoutObject) {
3280 if (!layoutObject) { 3285 if (!layoutObject) {
3281 LOG(INFO) << "Cannot showLayerTree. Root is (nil)"; 3286 LOG(INFO) << "Cannot showLayerTree. Root is (nil)";
3282 return; 3287 return;
3283 } 3288 }
3284 showLayerTree(layoutObject->enclosingLayer()); 3289 showLayerTree(layoutObject->enclosingLayer());
3285 } 3290 }
3286 #endif 3291 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698