[Devtools] Add experiment for network group support

[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG=664704
Committed: https://crrev.com/2878e413939ca755242d198304226fb83c5e4963
Cr-Commit-Position: refs/heads/master@{#439711}

[allada, 2016-12-08 00:40:40]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[allada, 2016-12-08 00:40:45]

PTL

[commit-bot: I haz the power, 2016-12-08 00:41:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 03:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 03:17:18]

Dry run: This issue passed the CQ dry run.

[allada, 2016-12-14 23:17:06]

Description was changed from

==========
[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

R=dgozman
BUG=664704
==========

to

==========
[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with
time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG=664704
==========

[allada, 2016-12-14 23:17:12]

PTL

[allada, 2016-12-14 23:17:19]

Patchset #1 (id:1) has been deleted

[allada, 2016-12-14 23:17:24]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2016-12-14 23:26:40]

Patchset #1 (id:20001) has been deleted

[allada, 2016-12-14 23:26:45]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:27:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2016-12-14 23:44:31]

Patchset #2 (id:60001) has been deleted

[allada, 2016-12-14 23:45:01]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[allada, 2016-12-14 23:45:08]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-12-14 23:45:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:41:14]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dgozman, 2016-12-15 03:04:42]

Looks very good.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:53:
static NameComparator(a, b) {
We should move these to interface in next patch.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:697:
_requestProperty(propertyName) {
Unused.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:774:
Network.NetworkDataGridNodeInterface = class {
Let's follow up with NetworkNode, NetworkRequestNode and NetworkGroupNode.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:76: /**
@type {!Map.<string, !Network.NetworkDataGridParentNode>} */
NetworkDataGridGroupNode

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:809: var
groupRequests = Runtime.experiments.isEnabled('networkGroupingRequests');
Unused.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:860:
_parentNodeForInsert(node) {
JSDoc

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:299:
var dataGridNode = node.asDataNode();
asRequestNode, asGroupNode

[allada, 2016-12-19 22:44:29]

PTaL

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
(right):

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:697:
_requestProperty(propertyName) {
On 2016/12/15 03:04:41, dgozman wrote:
> Unused.

Done.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:774:
Network.NetworkDataGridNodeInterface = class {
On 2016/12/15 03:04:41, dgozman wrote:
> Let's follow up with NetworkNode, NetworkRequestNode and NetworkGroupNode.

Done.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:76: /**
@type {!Map.<string, !Network.NetworkDataGridParentNode>} */
On 2016/12/15 03:04:41, dgozman wrote:
> NetworkDataGridGroupNode

Done.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:809: var
groupRequests = Runtime.experiments.isEnabled('networkGroupingRequests');
On 2016/12/15 03:04:41, dgozman wrote:
> Unused.

Done.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:860:
_parentNodeForInsert(node) {
On 2016/12/15 03:04:41, dgozman wrote:
> JSDoc

Done.

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2561683003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:299:
var dataGridNode = node.asDataNode();
On 2016/12/15 03:04:41, dgozman wrote:
> asRequestNode, asGroupNode

Done.

[dgozman, 2016-12-20 01:17:50]

lgtm

[allada, 2016-12-20 01:35:43]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-12-20 01:36:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2016-12-20 02:06:03]

The CQ bit was checked by allada@chromium.org

[allada, 2016-12-20 02:06:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2561683003/#ps140001
(title: "fix test")

[commit-bot: I haz the power, 2016-12-20 02:06:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:55:58]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482199563984450,
"parent_rev": "a2ba9b4185de3a1b7f0c1d9488500a1e8e472536", "commit_rev":
"b131e52999961f4533914dc7d8031e0954ae6a3e"}

[commit-bot: I haz the power, 2016-12-20 04:56:24]

Description was changed from

==========
[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with
time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG=664704
==========

to

==========
[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with
time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG=664704

Review-Url: https://codereview.chromium.org/2561683003
==========

[commit-bot: I haz the power, 2016-12-20 04:56:25]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-12-20 04:58:00]

Description was changed from

==========
[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with
time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG=664704

Review-Url: https://codereview.chromium.org/2561683003
==========

to

==========
[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with
time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG=664704

Committed: https://crrev.com/2878e413939ca755242d198304226fb83c5e4963
Cr-Commit-Position: refs/heads/master@{#439711}
==========

[commit-bot: I haz the power, 2016-12-20 04:58:01]

Patchset 4 (id:??) landed as
https://crrev.com/2878e413939ca755242d198304226fb83c5e4963
Cr-Commit-Position: refs/heads/master@{#439711}