Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: components/cryptauth/cryptauth_device_manager.h

Issue 2561683002: Update CryptAuthDeviceManager to store all synced devices instead of only unlock keys. (Closed)
Patch Set: tengs@ comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cryptauth/cryptauth_device_manager.h
diff --git a/components/cryptauth/cryptauth_device_manager.h b/components/cryptauth/cryptauth_device_manager.h
index 9f3602fd949ade0ee6064b111cfcb8ce6adc9486..023352dca1fbc69629b2e9f1b34dcc9fe4b99d73 100644
--- a/components/cryptauth/cryptauth_device_manager.h
+++ b/components/cryptauth/cryptauth_device_manager.h
@@ -105,10 +105,14 @@ class CryptAuthDeviceManager : public SyncScheduler::Delegate,
// has ever been recorded, then this function will also return true.
bool IsRecoveringFromFailure() const;
+ // Returns a list of all remote devices that have been synced.
+ std::vector<cryptauth::ExternalDeviceInfo> synced_devices() const;
Tim Song 2016/12/08 00:38:56 I would also CamelCase this function as well since
Kyle Horimoto 2016/12/08 00:46:33 Done.
+
// Returns a list of remote devices that can unlock the user's other devices.
- const std::vector<cryptauth::ExternalDeviceInfo>& unlock_keys() const {
- return unlock_keys_;
- }
+ std::vector<cryptauth::ExternalDeviceInfo> UnlockKeys() const;
Tim Song 2016/12/08 00:38:56 By convention, this should be GetUnlockKeys().
Kyle Horimoto 2016/12/08 00:46:33 Done.
+
+ // Returns a list of remote devices that can host tether hotspots.
+ std::vector<cryptauth::ExternalDeviceInfo> TetherHosts() const;
Tim Song 2016/12/08 00:38:56 By convention, this should be GetTetherHosts().
Kyle Horimoto 2016/12/08 00:46:33 Done.
protected:
// Creates a new SyncScheduler instance. Exposed for testing.
@@ -144,8 +148,8 @@ class CryptAuthDeviceManager : public SyncScheduler::Delegate,
// instance.
PrefService* const pref_service_;
- // The unlock keys currently synced from CryptAuth.
- std::vector<cryptauth::ExternalDeviceInfo> unlock_keys_;
+ // All devices currently synced from CryptAuth.
+ std::vector<cryptauth::ExternalDeviceInfo> synced_devices_;
// Schedules the time between device sync attempts.
std::unique_ptr<SyncScheduler> scheduler_;
« no previous file with comments | « chrome/browser/signin/easy_unlock_service_regular.cc ('k') | components/cryptauth/cryptauth_device_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698