Update CryptAuthDeviceManager to store all synced devices instead of only unlock keys.

components/cryptauth/cryptauth_device_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PROXIMITY_AUTH_CRYPTAUTH_CRYPTAUTH_DEVICE_MANAGER_H
 #define COMPONENTS_PROXIMITY_AUTH_CRYPTAUTH_CRYPTAUTH_DEVICE_MANAGER_H
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 87 matching lines @@
   base::TimeDelta GetTimeToNextAttempt() const;
 
   // Returns true if a device sync attempt is currently in progress.
   bool IsSyncInProgress() const;
 
   // Returns true if the last device sync failed and the manager is now
   // scheduling sync attempts more aggressively to recover. If no enrollment
   // has ever been recorded, then this function will also return true.
   bool IsRecoveringFromFailure() const;
 
+  // Returns a list of all remote devices that have been synced.
+  std::vector<cryptauth::ExternalDeviceInfo> synced_devices() const;

[Tim Song, 2016/12/08 00:38:56]

I would also CamelCase this function as well since you're defining it in the .cc
file.

[Kyle Horimoto, 2016/12/08 00:46:33]

Done.

+
   // Returns a list of remote devices that can unlock the user's other devices.
-  const std::vector<cryptauth::ExternalDeviceInfo>& unlock_keys() const {
-    return unlock_keys_;
-  }
+  std::vector<cryptauth::ExternalDeviceInfo> UnlockKeys() const;

[Tim Song, 2016/12/08 00:38:56]

By convention, this should be GetUnlockKeys().

[Kyle Horimoto, 2016/12/08 00:46:33]

Done.

+
+  // Returns a list of remote devices that can host tether hotspots.
+  std::vector<cryptauth::ExternalDeviceInfo> TetherHosts() const;

[Tim Song, 2016/12/08 00:38:56]

By convention, this should be GetTetherHosts().

[Kyle Horimoto, 2016/12/08 00:46:33]

Done.

 
  protected:
   // Creates a new SyncScheduler instance. Exposed for testing.
   virtual std::unique_ptr<SyncScheduler> CreateSyncScheduler();
 
  private:
   // CryptAuthGCMManager::Observer:
   void OnResyncMessage() override;
 
   // Updates |unlock_keys_| by fetching the list stored in |pref_service_|.
@@ skipping 15 matching lines @@
 
   // Notifies when GCM push messages trigger device sync. Not owned and must
   // outlive this instance.
   CryptAuthGCMManager* gcm_manager_;
 
   // Contains preferences that outlive the lifetime of this object and across
   // process restarts. |pref_service_| must outlive the lifetime of this
   // instance.
   PrefService* const pref_service_;
 
-  // The unlock keys currently synced from CryptAuth.
-  std::vector<cryptauth::ExternalDeviceInfo> unlock_keys_;
+  // All devices currently synced from CryptAuth.
+  std::vector<cryptauth::ExternalDeviceInfo> synced_devices_;
 
   // Schedules the time between device sync attempts.
   std::unique_ptr<SyncScheduler> scheduler_;
 
   // Contains the SyncRequest that |scheduler_| requests when a device sync
   // attempt is made.
   std::unique_ptr<SyncScheduler::SyncRequest> sync_request_;
 
   // The CryptAuthEnroller instance for the current sync attempt. A new
   // instance will be created for each individual attempt.
   std::unique_ptr<CryptAuthClient> cryptauth_client_;
 
   // List of observers.
   base::ObserverList<Observer> observers_;
 
   base::WeakPtrFactory<CryptAuthDeviceManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CryptAuthDeviceManager);
 };
 
 }  // namespace cryptauth
 
 #endif  // COMPONENTS_PROXIMITY_CRYPTAUTH_CRYPTAUTH_DEVICE_MANAGER_H