Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2561603003: Add encoding time and and fps to webrtc.stress case. (Closed)

Created:
4 years ago by phoglund_chromium
Modified:
4 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add encoding time and and fps to webrtc.stress case. This is going to show the metrics for the first 5 peer connections; I hope that's enough since showing all 30 makes the test really annoying to triage. BUG=632299 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/e12e3f48116008ebb8cd4b72b90828645b2f5a22 Cr-Commit-Position: refs/heads/master@{#438131}

Patch Set 1 #

Patch Set 2 : Don't log more than 5 conns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -20 lines) Patch
M tools/perf/benchmarks/webrtc.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/webrtc.py View 3 chunks +13 lines, -9 lines 0 comments Download
M tools/perf/metrics/webrtc_stats.py View 1 4 chunks +29 lines, -4 lines 0 comments Download
M tools/perf/metrics/webrtc_stats_unittest.py View 4 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
phoglund_chromium
Edward: main review Annie: owner stamp
4 years ago (2016-12-07 15:57:34 UTC) #3
ehmaldonado_chromium
On 2016/12/07 15:57:34, phoglund_chrome wrote: > Edward: main review > Annie: owner stamp lgtm
4 years ago (2016-12-07 16:16:16 UTC) #4
sullivan
lgtm
4 years ago (2016-12-12 17:53:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561603003/20001
4 years ago (2016-12-13 09:46:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 11:43:43 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 11:45:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e12e3f48116008ebb8cd4b72b90828645b2f5a22
Cr-Commit-Position: refs/heads/master@{#438131}

Powered by Google App Engine
This is Rietveld 408576698