Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2561573002: Remove ContextLifecycleObserver from V8V0CustomElementLifecycleCallbacks (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from V8V0CustomElementLifecycleCallbacks It's not needed because V8V0CustomElementLifecycleCallbacks already holds ScriptState. BUG=610176 Committed: https://crrev.com/12d08d987d13508e34d9abbd01f062927f2eee90 Cr-Commit-Position: refs/heads/master@{#436960}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp View 8 chunks +7 lines, -18 lines 3 comments Download

Messages

Total messages: 12 (4 generated)
haraken
PTAL
4 years ago (2016-12-07 11:48:03 UTC) #2
sof
https://codereview.chromium.org/2561573002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp File third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp (left): https://codereview.chromium.org/2561573002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp#oldcode154 third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:154: if (!getExecutionContext() || getExecutionContext()->isContextDestroyed()) Can you clarify why the ...
4 years ago (2016-12-07 12:14:59 UTC) #3
haraken
https://codereview.chromium.org/2561573002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp File third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp (left): https://codereview.chromium.org/2561573002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp#oldcode154 third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:154: if (!getExecutionContext() || getExecutionContext()->isContextDestroyed()) On 2016/12/07 12:14:59, sof wrote: ...
4 years ago (2016-12-07 12:17:21 UTC) #4
sof
lgtm https://codereview.chromium.org/2561573002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp File third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp (left): https://codereview.chromium.org/2561573002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp#oldcode154 third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp:154: if (!getExecutionContext() || getExecutionContext()->isContextDestroyed()) On 2016/12/07 12:17:21, haraken ...
4 years ago (2016-12-07 12:25:14 UTC) #5
haraken
On 2016/12/07 12:25:14, sof wrote: > lgtm > > https://codereview.chromium.org/2561573002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp > File > third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp > ...
4 years ago (2016-12-07 12:50:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561573002/1
4 years ago (2016-12-07 12:51:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 15:21:23 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 15:22:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12d08d987d13508e34d9abbd01f062927f2eee90
Cr-Commit-Position: refs/heads/master@{#436960}

Powered by Google App Engine
This is Rietveld 408576698