Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2561533002: dart2js: Constant folding and specialization for remainder (Closed)

Created:
4 years ago by sra1
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Constant folding and specialization for remainder. modulo "a.remainder(b)" can be compiled to "a % b" "a % b" can be compiled to "a % b" in some limited circumstances. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/fd44f86cfb93faaa2477ac446eafc8a94a1b6a50

Patch Set 1 #

Patch Set 2 : fix range analysis #

Total comments: 2

Patch Set 3 : fix comment #

Patch Set 4 : merge and format #

Patch Set 5 : improve range analysis of remainder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -3 lines) Patch
M pkg/compiler/lib/src/constant_system_dart.dart View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 2 3 2 chunks +83 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 2 3 4 4 chunks +16 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 2 3 4 2 chunks +26 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/modulo_remainder_test.dart View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sra1
WDYT? Probably best to wait until I'm back from vacation to commit. The modulo replacement ...
4 years ago (2016-12-08 05:28:07 UTC) #3
Siggi Cherem (dart-lang)
neat - lgtm, totally worth trying it out https://codereview.chromium.org/2561533002/diff/20001/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart File pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart (right): https://codereview.chromium.org/2561533002/diff/20001/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart#newcode332 pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart:332: // ...
4 years ago (2016-12-08 14:54:29 UTC) #4
sra1
https://codereview.chromium.org/2561533002/diff/20001/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart File pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart (right): https://codereview.chromium.org/2561533002/diff/20001/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart#newcode332 pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart:332: // '+' is can only generate -0.0 when both ...
4 years ago (2016-12-08 20:43:44 UTC) #5
sra1
3 years, 11 months ago (2017-01-05 17:59:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
fd44f86cfb93faaa2477ac446eafc8a94a1b6a50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698