Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: tests/compiler/dart2js/modulo_remainder_test.dart

Issue 2561533002: dart2js: Constant folding and specialization for remainder (Closed)
Patch Set: improve range analysis of remainder Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/value_range_analyzer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/modulo_remainder_test.dart
diff --git a/tests/compiler/dart2js/modulo_remainder_test.dart b/tests/compiler/dart2js/modulo_remainder_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..a391a345dec89eb3784a58dbadc591d55b55f20d
--- /dev/null
+++ b/tests/compiler/dart2js/modulo_remainder_test.dart
@@ -0,0 +1,100 @@
+// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:async';
+import 'package:expect/expect.dart';
+import 'package:async_helper/async_helper.dart';
+import 'compiler_helper.dart';
+
+const String MOD1 = r"""
+foo(param) {
+ var a = param ? 0xFFFFFFFF : 1;
+ return a % 2;
+ // present: ' % 2'
+ // absent: '$mod'
+}
+""";
+
+const String MOD2 = r"""
+foo(param) {
+ var a = param ? 0xFFFFFFFF : -0.0;
+ return a % 2;
+ // Cannot optimize due to potential -0.
+ // present: '$mod'
+ // absent: ' % 2'
+}
+""";
+
+const String MOD3 = r"""
+foo(param) {
+ var a = param ? 0xFFFFFFFF : -0.0;
+ return (a + 1) % 2;
+ // 'a + 1' cannot be -0.0, so we can optimize.
+ // present: ' % 2'
+ // absent: '$mod'
+}
+""";
+
+const String REM1 = r"""
+foo(param) {
+ var a = param ? 0xFFFFFFFF : 1;
+ return a.remainder(2);
+ // Above can be compiled to '%'.
+ // present: ' % 2'
+ // absent: 'remainder'
+}
+""";
+
+const String REM2 = r"""
+foo(param) {
+ var a = param ? 123.4 : -1;
+ return a.remainder(3);
+ // Above can be compiled to '%'.
+ // present: ' % 3'
+ // absent: 'remainder'
+}
+""";
+
+const String REM3 = r"""
+foo(param) {
+ var a = param ? 123 : null;
+ return 100.remainder(a);
+ // No specialization for possibly null inputs.
+ // present: 'remainder'
+ // absent: '%'
+}
+""";
+
+main() {
+ RegExp directivePattern = new RegExp(
+ // \1 \2 \3
+ r'''// *(present|absent): (?:"([^"]*)"|'([^'']*)')''',
+ multiLine: true);
+
+ Future check(String test) {
+ return compile(test, entry: 'foo', check: (String generated) {
+ for (Match match in directivePattern.allMatches(test)) {
+ String directive = match.group(1);
+ String pattern = match.groups([2, 3]).where((s) => s != null).single;
+ if (directive == 'present') {
+ Expect.isTrue(generated.contains(pattern),
+ "Cannot find '$pattern' in:\n$generated");
+ } else {
+ assert(directive == 'absent');
+ Expect.isFalse(generated.contains(pattern),
+ "Must not find '$pattern' in:\n$generated");
+ }
+ }
+ });
+ }
+
+ asyncTest(() => Future.wait([
+ check(MOD1),
+ check(MOD2),
+ check(MOD3),
+ check(REM1),
+ check(REM2),
+ check(REM3),
+ ]));
+}
« no previous file with comments | « pkg/compiler/lib/src/ssa/value_range_analyzer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698