MD Settings: Bluetooth: Make top level UI consistent

MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=672772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7ad02f9ac069e7f594b5f385bd20286e420bfd93
Cr-Commit-Position: refs/heads/master@{#438332}

[stevenjb, 2016-12-09 01:13:06]

Description was changed from

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=none
==========

to

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-09 01:13:33]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org

[stevenjb, 2016-12-09 16:53:20]

stevenjb@chromium.org changed reviewers:
+ fukino@chromium.org

[fukino, 2016-12-12 03:56:48]

On 2016/12/09 16:53:21, stevenjb wrote:

Could you add issue 672772 to the BUG line? Thanks!

[stevenjb, 2016-12-12 17:38:10]

Description was changed from

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=672772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-12 17:38:19]

On 2016/12/12 03:56:48, fukino wrote:
> On 2016/12/09 16:53:21, stevenjb wrote:
> 
> Could you add issue 672772 to the BUG line? Thanks!

Done.

[stevenjb, 2016-12-12 17:38:21]

On 2016/12/12 03:56:48, fukino wrote:
> On 2016/12/09 16:53:21, stevenjb wrote:
> 
> Could you add issue 672772 to the BUG line? Thanks!

Done.

[dschuyler, 2016-12-13 00:48:01]

https://codereview.chromium.org/2561463005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
(right):

https://codereview.chromium.org/2561463005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html:46: <span
class="middle flex">$i18n{bluetoothEnable}</span>
I suspect that line 44 and 56 could be deleted, along with deleting the flex
class entry in line 46. i.e. I'd expect the UI to layout the same after those
deletions.

[stevenjb, 2016-12-13 19:07:46]

Also renamed doNothing -> stopTap for consistency with cr-expand-button changes.

https://codereview.chromium.org/2561463005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
(right):

https://codereview.chromium.org/2561463005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html:46: <span
class="middle flex">$i18n{bluetoothEnable}</span>
On 2016/12/13 00:48:01, dschuyler wrote:
> I suspect that line 44 and 56 could be deleted, along with deleting the flex
> class entry in line 46. i.e. I'd expect the UI to layout the same after those
> deletions.

Done.

[dschuyler, 2016-12-13 19:29:05]

lgtm

[stevenjb, 2016-12-13 19:40:50]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2016-12-13 19:41:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:09:36]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-12-13 21:13:03]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-12-13 21:13:04]

https://codereview.chromium.org/2561463005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js (right):

https://codereview.chromium.org/2561463005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js:582:
event.stopPropagation();
try your code ;)

[Dan Beam, 2016-12-13 21:14:53]

https://codereview.chromium.org/2561463005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js (right):

https://codereview.chromium.org/2561463005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js:582:
event.stopPropagation();
On 2016/12/13 21:13:03, Dan Beam wrote:
> try your code ;)

(also, fwiw, this could work for deep/dark reasons,
https://developer.mozilla.org/en-US/docs/Web/API/Window/event, sorry if I was
assuming it didn't and the compiler is just wrong)

obviously, everybody's happy if you just add a param named |event|

[stevenjb, 2016-12-13 22:01:32]

https://codereview.chromium.org/2561463005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js (right):

https://codereview.chromium.org/2561463005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js:582:
event.stopPropagation();
On 2016/12/13 21:14:53, Dan Beam wrote:
> On 2016/12/13 21:13:03, Dan Beam wrote:
> > try your code ;)
> 
> (also, fwiw, this could work for deep/dark reasons,
> https://developer.mozilla.org/en-US/docs/Web/API/Window/event, sorry if I was
> assuming it didn't and the compiler is just wrong)
> 
> obviously, everybody's happy if you just add a param named |event|

I did. Apparently it works for deep/dark reasons.

Clearly I forgot to run closure however.

Fixed.

[stevenjb, 2016-12-13 22:01:35]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-12-13 22:01:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2561463005/#ps60001
(title: "Fix closure and implicit event")

[commit-bot: I haz the power, 2016-12-13 22:02:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:22:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481666495785650,
"parent_rev": "c82c66c85ca5d3908344cac855ad90c340980b3a", "commit_rev":
"308cb8968e7ea273021ddb8b5d6a7c432f758caf"}

[commit-bot: I haz the power, 2016-12-13 23:23:35]

Description was changed from

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=672772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=672772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2561463005
==========

[commit-bot: I haz the power, 2016-12-13 23:23:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 23:26:32]

Description was changed from

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=672772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2561463005
==========

to

==========
MD Settings: Bluetooth: Make top level UI consistent

This embeds the toggle button in a secondary action div to make the
Bluetooth UI consistent with other UI.

BUG=672772
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7ad02f9ac069e7f594b5f385bd20286e420bfd93
Cr-Commit-Position: refs/heads/master@{#438332}
==========

[commit-bot: I haz the power, 2016-12-13 23:26:33]

Patchset 4 (id:??) landed as
https://crrev.com/7ad02f9ac069e7f594b5f385bd20286e420bfd93
Cr-Commit-Position: refs/heads/master@{#438332}