Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 2561403003: Use getDataBufferingPolicy() instead of the redundant dataBufferingPolicy(). (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use getDataBufferingPolicy() instead of the redundant dataBufferingPolicy(). Before this CL, blink::Resource class would define 2 almost identical methods: - Same const-ness - Same return type - Same body - Different name and access: public |getDataBufferingPolicy| and protected |dataBufferingPolicy|. This CL removes the redundant dataBufferingPolicy() and tweaks the only caller of the removed method to call getDataBufferingPolicy() instead. This CL helps with rewrite_to_chrome_style which would have renamed dataBufferingPolicy to getDataBufferingPolicy to avoid type-vs-method name conflict (see r414550 and r417471). Such rename would mean two definitions of the same method and so would mean a build error. BUG=582312 Committed: https://crrev.com/9fe321541270204571bfdbd4c14995046bc3986e Cr-Commit-Position: refs/heads/master@{#437625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Łukasz Anforowicz
Daniel, can you take a look please?
4 years ago (2016-12-09 18:02:23 UTC) #4
dcheng
lgtm
4 years ago (2016-12-09 18:20:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561403003/1
4 years ago (2016-12-09 18:22:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 20:30:55 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 14:37:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fe321541270204571bfdbd4c14995046bc3986e
Cr-Commit-Position: refs/heads/master@{#437625}

Powered by Google App Engine
This is Rietveld 408576698