Revert making trying to authorize a nonsense device id a bad_message.

Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167
Committed: https://crrev.com/d548859dc67b223acef855cfce6e7e92c2ec34b7
Cr-Commit-Position: refs/heads/master@{#437933}

[Max Morin, 2016-12-09 12:59:00]

Description was changed from

==========
Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167
==========

to

==========
Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167
==========

[Max Morin, 2016-12-09 12:59:00]

maxmorin@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[Max Morin, 2016-12-09 13:04:55]

Dale: PTAL at this small CL.

+CC people from the bug.

[DaleCurtis, 2016-12-09 22:33:59]

Do we want to allow junk to be sent over like this? Seems like it could allow
probing.

[Max Morin, 2016-12-12 08:11:39]

On 2016/12/09 22:33:59, DaleCurtis wrote:
> Do we want to allow junk to be sent over like this? Seems like it could allow
> probing.

It would be nice to track down what is causing these ids to be sent (it is
possible with setSinkId, but I don't think that's what's causing this in the
wild, as I wrote in the bug). Either way, I don't see how it allows probing in
this case (to check for actual device ids, access is needed first), and even if
we check the format of the device id on the renderer-side, we will still need to
check it on the browser-side (or just let it fail to translate, I guess).

[Guido Urdaneta, 2016-12-12 09:24:02]

On 2016/12/09 22:33:59, DaleCurtis wrote:
> Do we want to allow junk to be sent over like this? Seems like it could allow
> probing.

Probing can be done more easily by calling enumerateDevices from JS.
That will return all valid device IDs, although human-readable descriptions will
be available only if the user has given permission to the origin.

[DaleCurtis, 2016-12-12 18:33:56]

lgtm then, though we generally perform strict error checks where possible for
unexpected behavior.

[Max Morin, 2016-12-12 19:45:37]

The CQ bit was checked by maxmorin@chromium.org

[commit-bot: I haz the power, 2016-12-12 19:46:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 22:37:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481571937327760, "parent_rev":
"fbcb714d1a0be8d8d386f298409132a3e5c31e32", "commit_rev":
"4bc5850eb11762990ee929e46397e519050257cd"}

[commit-bot: I haz the power, 2016-12-12 22:38:24]

Description was changed from

==========
Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167
==========

to

==========
Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167

Review-Url: https://codereview.chromium.org/2561343002
==========

[commit-bot: I haz the power, 2016-12-12 22:38:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 22:42:54]

Description was changed from

==========
Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167

Review-Url: https://codereview.chromium.org/2561343002
==========

to

==========
Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167

Committed: https://crrev.com/d548859dc67b223acef855cfce6e7e92c2ec34b7
Cr-Commit-Position: refs/heads/master@{#437933}
==========

[commit-bot: I haz the power, 2016-12-12 22:42:55]

Patchset 1 (id:??) landed as
https://crrev.com/d548859dc67b223acef855cfce6e7e92c2ec34b7
Cr-Commit-Position: refs/heads/master@{#437933}