[wasm] Remove declared but undefined methods

[wasm] Remove declared but undefined methods

We should really think about having a static analysis to check for
such errors, and a bot executing it regularly.
This is not the first time I encounter declared functions that are
never defined.

R=titzer@chromium.org

Committed: https://crrev.com/0868b76bb1e0aeec656b5f2942a7e470a2b8acb1
Cr-Commit-Position: refs/heads/master@{#41617}

[Clemens Hammacher, 2016-12-09 12:29:56]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 12:29:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 12:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 12:54:44]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-12-09 12:56:17]

Description was changed from

==========
[wasm] Remove declared but undefined methods

We should really think about having a bot to check for such errors.
This is not the first time I encounter declared functions that are
never defined.

R=titzer@chromium.org
==========

to

==========
[wasm] Remove declared but undefined methods

We should really think about having a static analysis to check for
such errors, and a bot executing it regularly.
This is not the first time I encounter declared functions that are
never defined.

R=titzer@chromium.org
==========

[titzer, 2016-12-09 13:57:08]

lgtm

I had planned to move some methods from wasm-module.h to be member methods, but
didn't get around to it yet.

[Clemens Hammacher, 2016-12-09 13:59:00]

On 2016/12/09 at 13:57:08, titzer wrote:
> lgtm
> 
> I had planned to move some methods from wasm-module.h to be member methods,
but didn't get around to it yet.

Most of those methods have already moved to either WasmCompiledModule or
WasmInstanceObject by now :)

[Clemens Hammacher, 2016-12-09 13:59:06]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-12-09 13:59:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 14:01:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481291946774760, "parent_rev":
"3cc731f50def717113dc4a7e50d540d9dfc436d0", "commit_rev":
"5948ebc8f52efc824cde8addcc8c48f4cf1f5f78"}

[commit-bot: I haz the power, 2016-12-09 14:01:13]

Description was changed from

==========
[wasm] Remove declared but undefined methods

We should really think about having a static analysis to check for
such errors, and a bot executing it regularly.
This is not the first time I encounter declared functions that are
never defined.

R=titzer@chromium.org
==========

to

==========
[wasm] Remove declared but undefined methods

We should really think about having a static analysis to check for
such errors, and a bot executing it regularly.
This is not the first time I encounter declared functions that are
never defined.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2561333002
==========

[commit-bot: I haz the power, 2016-12-09 14:01:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-09 14:01:37]

Description was changed from

==========
[wasm] Remove declared but undefined methods

We should really think about having a static analysis to check for
such errors, and a bot executing it regularly.
This is not the first time I encounter declared functions that are
never defined.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2561333002
==========

to

==========
[wasm] Remove declared but undefined methods

We should really think about having a static analysis to check for
such errors, and a bot executing it regularly.
This is not the first time I encounter declared functions that are
never defined.

R=titzer@chromium.org

Committed: https://crrev.com/0868b76bb1e0aeec656b5f2942a7e470a2b8acb1
Cr-Commit-Position: refs/heads/master@{#41617}
==========

[commit-bot: I haz the power, 2016-12-09 14:01:38]

Patchset 1 (id:??) landed as
https://crrev.com/0868b76bb1e0aeec656b5f2942a7e470a2b8acb1
Cr-Commit-Position: refs/heads/master@{#41617}