Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2561323002: Media Controls: don't try to cut the controls when the element is fullscreen. (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
Reviewers:
foolip
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Media Controls: don't try to cut the controls when the element is fullscreen. During the fullscreen animation, the reported position of the media element will be greater than 0 and it is sometimes not reset to 0 as it should be, leaving the controls cut on the right side. This a work around a fullscreen issue in order to avoid a regression. BUG=663680 R=foolip@chromium.org Review-Url: https://codereview.chromium.org/2550423003 Cr-Commit-Position: refs/heads/master@{#436937} (cherry picked from commit e4110ecc69aca6f4fb7b12ed9118844e8d883014) Committed: https://chromium.googlesource.com/chromium/src/+/e768d9ee7b5adaa6b95c0869b931e6468685fa88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutMedia.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
4 years ago (2016-12-09 12:02:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e768d9ee7b5adaa6b95c0869b931e6468685fa88.

Powered by Google App Engine
This is Rietveld 408576698