Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2550423003: Media Controls: don't try to cut the controls when the element is fullscreen. (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
Reviewers:
foolip
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, Srirama, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: don't try to cut the controls when the element is fullscreen. During the fullscreen animation, the reported position of the media element will be greater than 0 and it is sometimes not reset to 0 as it should be, leaving the controls cut on the right side. This a work around a fullscreen issue in order to avoid a regression. BUG=663680 R=foolip@chromium.org Committed: https://crrev.com/e4110ecc69aca6f4fb7b12ed9118844e8d883014 Cr-Commit-Position: refs/heads/master@{#436937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutMedia.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mlamouri (slow - plz ping)
Oups, I forgot to "publish" this. foolip@, PTAL :)
4 years ago (2016-12-07 11:34:55 UTC) #6
foolip
lgtm
4 years ago (2016-12-07 13:49:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550423003/1
4 years ago (2016-12-07 13:49:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 13:54:07 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 13:57:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4110ecc69aca6f4fb7b12ed9118844e8d883014
Cr-Commit-Position: refs/heads/master@{#436937}

Powered by Google App Engine
This is Rietveld 408576698