Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2561293002:
[ios] Removed //components/prefs dependency from net. (Closed)
|
Created:
4 years ago by Eugene But (OOO till 7-30) Modified:
4 years ago Reviewers:
davidben CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ios] Removed //components/prefs dependency from net.
This removes 20 files from //net compilation.
BUG=672672
Committed: https://crrev.com/9a50f58c3d2612b162feb9c098c971f892024d48
Cr-Commit-Position: refs/heads/master@{#437588}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [ios] Removed //components/prefs dependency from net. BUG=672672 ========== to ========== [ios] Removed //components/prefs dependency from net. This removes 20 files for net compilation. BUG=672672 ==========
Description was changed from ========== [ios] Removed //components/prefs dependency from net. This removes 20 files for net compilation. BUG=672672 ========== to ========== [ios] Removed //components/prefs dependency from net. This removes 20 files from //net compilation. BUG=672672 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
eugenebut@chromium.org changed reviewers: + davidben@chromium.org
Is it even ok that net had dependency on components?
lgtm. Huh. I wonder how that got in there! There's probably some long and sordid history, but seems to be gone now. (That said, if the concern is binary size, I would have expected the static linker to have dropped the dependency. There might be some easy savings to be gotten by tweaking build flags? Anyway, this is a good change regardless.)
Thanks!
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481305916150860, "parent_rev":
"4337f7912fba2a0929d662f322c028c0137afae2", "commit_rev":
"1610b765f8530ed0a66d9d23f12c91d3eac0abb9"}
Message was sent while issue was closed.
Description was changed from ========== [ios] Removed //components/prefs dependency from net. This removes 20 files from //net compilation. BUG=672672 ========== to ========== [ios] Removed //components/prefs dependency from net. This removes 20 files from //net compilation. BUG=672672 Review-Url: https://codereview.chromium.org/2561293002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [ios] Removed //components/prefs dependency from net. This removes 20 files from //net compilation. BUG=672672 Review-Url: https://codereview.chromium.org/2561293002 ========== to ========== [ios] Removed //components/prefs dependency from net. This removes 20 files from //net compilation. BUG=672672 Committed: https://crrev.com/9a50f58c3d2612b162feb9c098c971f892024d48 Cr-Commit-Position: refs/heads/master@{#437588} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9a50f58c3d2612b162feb9c098c971f892024d48 Cr-Commit-Position: refs/heads/master@{#437588} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
