[ios] Excluded harfbuzz-ng and events code

[ios] Excluded harfbuzz-ng and events code from ui library.

events_unittests was fully excluded for ios.

This removes ~70 files + tests from ui/base target and improves
ios_web_shell sys build time by 10%.

BUG=672672
Committed: https://crrev.com/4a5e6b501568d0890ec05f14e830e212cb71e3e1
Cr-Commit-Position: refs/heads/master@{#439622}

[Eugene But (OOO till 7-30), 2016-12-09 02:31:17]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2016-12-09 02:31:32]

https://codereview.chromium.org/2561263003/diff/1/ui/events/BUILD.gn
File ui/events/BUILD.gn (right):

https://codereview.chromium.org/2561263003/diff/1/ui/events/BUILD.gn#newcode80
ui/events/BUILD.gn:80: ":event_constants",
ios needs one header from events (event_constants.h)

https://codereview.chromium.org/2561263003/diff/1/ui/events/BUILD.gn#newcode355
ui/events/BUILD.gn:355: test("events_unittests") {
These are just indentations.

[commit-bot: I haz the power, 2016-12-09 02:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 02:38:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 02:38:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Eugene But (OOO till 7-30), 2016-12-09 02:54:46]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 02:55:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-12-09 04:06:30]

eugenebut@chromium.org changed reviewers:
+ thakis@chromium.org

[Eugene But (OOO till 7-30), 2016-12-09 04:37:11]

Description was changed from

==========
[ios] Excluded unused files form ui library.

This removes 90 files + tests from ui/display, ui/gfx and ui/base.
ui/events is fully removed as unneeded.

BUG=672672
==========

to

==========
[ios] Excluded unused files form ui library.

This removes 90 files + tests from ui/display, ui/gfx and ui/base.
ui/events is fully removed as unneeded (except one header which
was moved to a separate events_constants target).

BUG=672672
==========

[Eugene But (OOO till 7-30), 2016-12-09 04:37:46]

Description was changed from

==========
[ios] Excluded unused files form ui library.

This removes 90 files + tests from ui/display, ui/gfx and ui/base.
ui/events is fully removed as unneeded (except one header which
was moved to a separate events_constants target).

BUG=672672
==========

to

==========
[ios] Excluded unused files form ui library.

This removes 90 files + tests from ui/display, ui/gfx and ui/base.
events_unittests and ui/events are fully removed as unneeded (except
one header which was moved to a separate events_constants target).

BUG=672672
==========

[commit-bot: I haz the power, 2016-12-09 04:39:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 04:40:00]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-12-09 12:18:12]

Here's how this looked in my inbox: http://m.imgur.com/4EaBKCw When adding
people later to a review, please include a short note saying what you want
them to do.

On Dec 8, 2016 11:06 PM, <eugenebut@chromium.org> wrote:

> https://codereview.chromium.org/2561263003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-12-09 12:20:16]

https://codereview.chromium.org/2561263003/diff/20001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/2561263003/diff/20001/ui/base/BUILD.gn#newcod...
ui/base/BUILD.gn:398: deps -= [ "//ui/events" ]
Rather than adding this unconditionally and the remove it conditionally, only
add it when needed in the first place (also elsewhere)

[Nico, 2016-12-09 12:27:50]

Hm, this seems pretty ad hoc. I believe that e.g. the Insets code isn't used on
iOS), but that seems more like a coincidence. It might be used in the future.
And the linker will not include unused .o files from archives. Is the motivation
build time? The patch is kind of sprinkling #ifdefs all over; maybe there's some
more principled way (splitting targets by semantics somehow instead of offing
out everything that happens to be not used on iOS today)

[Eugene But (OOO till 7-30), 2016-12-09 20:25:48]

Description was changed from

==========
[ios] Excluded unused files form ui library.

This removes 90 files + tests from ui/display, ui/gfx and ui/base.
events_unittests and ui/events are fully removed as unneeded (except
one header which was moved to a separate events_constants target).

BUG=672672
==========

to

==========
[ios] Excluded unused files from ui.base library.

This removes 75 files + tests from ui/base compilation on iOS.

BUG=672672
==========

[Eugene But (OOO till 7-30), 2016-12-09 20:26:02]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 20:26:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-12-09 20:39:35]

Description was changed from

==========
[ios] Excluded unused files from ui.base library.

This removes 75 files + tests from ui/base compilation on iOS.

BUG=672672
==========

to

==========
[ios] Excluded harfbuzz-ng and even code from ui library.

This removes 90 files + tests from ui/display, ui/gfx and ui/base.
events_unittests and ui/events are fully removed as unneeded (except
one header which was moved to a separate events_constants target).

BUG=672672
==========

[Eugene But (OOO till 7-30), 2016-12-09 21:22:42]

I addressed your comments and excluded only libraries, not individual files.
PTAL.

[commit-bot: I haz the power, 2016-12-09 23:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 23:03:56]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-12-11 16:36:38]

Description was changed from

==========
[ios] Excluded harfbuzz-ng and even code from ui library.

This removes 90 files + tests from ui/display, ui/gfx and ui/base.
events_unittests and ui/events are fully removed as unneeded (except
one header which was moved to a separate events_constants target).

BUG=672672
==========

to

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

This removes ~70 files + tests from ui/base target.

BUG=672672
==========

[Eugene But (OOO till 7-30), 2016-12-11 17:45:35]

Description was changed from

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

This removes ~70 files + tests from ui/base target.

BUG=672672
==========

to

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

This removes ~70 files + tests from ui/base target.
Improves ios_web_shell sys build time by 10%.

BUG=672672
==========

[Eugene But (OOO till 7-30), 2016-12-11 17:52:03]

Description was changed from

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

This removes ~70 files + tests from ui/base target.
Improves ios_web_shell sys build time by 10%.

BUG=672672
==========

to

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

events_unittests was fully excluded for ios.

This removes ~70 files + tests from ui/base target and improves
ios_web_shell sys build time by 10%.

BUG=672672
==========

[Eugene But (OOO till 7-30), 2016-12-11 17:52:12]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 17:52:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 19:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 19:48:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Eugene But (OOO till 7-30), 2016-12-19 18:04:09]

Nico, PTAL

[Nico, 2016-12-19 20:55:08]

lgtm, thanks for bearing with me.

[Eugene But (OOO till 7-30), 2016-12-19 20:56:58]

Thank you!

[Eugene But (OOO till 7-30), 2016-12-19 20:57:06]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-19 20:57:14]

The CQ bit was unchecked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-19 21:02:46]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-19 21:02:47]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2561263003/#ps100001
(title: "Synced with origin/master")

[commit-bot: I haz the power, 2016-12-19 21:03:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 23:50:45]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482181366747090,
"parent_rev": "4c2a9eff92a81fe9dd790e2be53c8e2883634bba", "commit_rev":
"37765a52e934a4694765e4841f0d5b90aa1ff642"}

[commit-bot: I haz the power, 2016-12-19 23:51:12]

Description was changed from

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

events_unittests was fully excluded for ios.

This removes ~70 files + tests from ui/base target and improves
ios_web_shell sys build time by 10%.

BUG=672672
==========

to

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

events_unittests was fully excluded for ios.

This removes ~70 files + tests from ui/base target and improves
ios_web_shell sys build time by 10%.

BUG=672672

Review-Url: https://codereview.chromium.org/2561263003
==========

[commit-bot: I haz the power, 2016-12-19 23:51:13]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-19 23:55:08]

Description was changed from

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

events_unittests was fully excluded for ios.

This removes ~70 files + tests from ui/base target and improves
ios_web_shell sys build time by 10%.

BUG=672672

Review-Url: https://codereview.chromium.org/2561263003
==========

to

==========
[ios] Excluded harfbuzz-ng and events code from ui library.

events_unittests was fully excluded for ios.

This removes ~70 files + tests from ui/base target and improves
ios_web_shell sys build time by 10%.

BUG=672672

Committed: https://crrev.com/4a5e6b501568d0890ec05f14e830e212cb71e3e1
Cr-Commit-Position: refs/heads/master@{#439622}
==========

[commit-bot: I haz the power, 2016-12-19 23:55:09]

Patchset 6 (id:??) landed as
https://crrev.com/4a5e6b501568d0890ec05f14e830e212cb71e3e1
Cr-Commit-Position: refs/heads/master@{#439622}