|
|
DescriptionHide supervised user creation from UserManager when force sign in is enabled.
BUG=642059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/b74c0c839bc52d72add187ca55c0bf2eb60deaf8
Cr-Commit-Position: refs/heads/master@{#438194}
Patch Set 1 #
Total comments: 8
Patch Set 2 : moe's comments #
Total comments: 2
Patch Set 3 #
Messages
Total messages: 31 (20 generated)
Description was changed from ========== Hide supervised user creation from UserManager when force sign in is enabled. BUG=642059 ========== to ========== Hide supervised user creation from UserManager when force sign in is enabled. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by zmin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
zmin@chromium.org changed reviewers: + mahmadi@chromium.org
Hi mahmadi@ Can you review CL please.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by zmin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2561243002/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/create_profile.html (left): https://codereview.chromium.org/2561243002/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/create_profile.html:170: <div id="supervised-user-container"> this div still remains visible even isForceSigninEnabled_ is true. You can put the checkbox and this div inside a dom-if so that they won't get rendered altogether. https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right): https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/create_profile_tests.js:511: suite('CreateProfileTestsSupervisedUserCreationCheckBox', function() { nit: CreateProfileTestsForceSigninPolicy https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/create_profile_tests.js:525: test('Create profile without supervised checkbox', function () { nit: 'force sign in policy enabled' https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/create_profile_tests.js:537: test('Create profile with supervised checkbox', function () { nit: 'force sign in policy not enabled'
The CQ bit was checked by zmin@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2561243002/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/create_profile.html (left): https://codereview.chromium.org/2561243002/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/create_profile.html:170: <div id="supervised-user-container"> On 2016/12/11 22:11:40, moe wrote: > this div still remains visible even isForceSigninEnabled_ is true. You can put > the checkbox and this div inside a dom-if so that they won't get rendered > altogether. Done. https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right): https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/create_profile_tests.js:511: suite('CreateProfileTestsSupervisedUserCreationCheckBox', function() { On 2016/12/11 22:11:40, moe wrote: > nit: CreateProfileTestsForceSigninPolicy Done. https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/create_profile_tests.js:525: test('Create profile without supervised checkbox', function () { On 2016/12/11 22:11:40, moe wrote: > nit: 'force sign in policy enabled' Done. https://codereview.chromium.org/2561243002/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/create_profile_tests.js:537: test('Create profile with supervised checkbox', function () { On 2016/12/11 22:11:40, moe wrote: > nit: 'force sign in policy not enabled' Done.
lgtm with one comment. Thanks owen. https://codereview.chromium.org/2561243002/diff/40001/chrome/test/data/webui/... File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right): https://codereview.chromium.org/2561243002/diff/40001/chrome/test/data/webui/... chrome/test/data/webui/md_user_manager/create_profile_tests.js:541: assertEquals(null, createSupervisedUserCheckbox); do assertFalse(!!createSupervisedUserCheckbox) instead
https://codereview.chromium.org/2561243002/diff/40001/chrome/test/data/webui/... File chrome/test/data/webui/md_user_manager/create_profile_tests.js (right): https://codereview.chromium.org/2561243002/diff/40001/chrome/test/data/webui/... chrome/test/data/webui/md_user_manager/create_profile_tests.js:541: assertEquals(null, createSupervisedUserCheckbox); On 2016/12/12 21:13:01, moe wrote: > do assertFalse(!!createSupervisedUserCheckbox) instead Done.
The CQ bit was checked by zmin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mahmadi@chromium.org Link to the patchset: https://codereview.chromium.org/2561243002/#ps60001 (title: "")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zmin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481643364310270, "parent_rev": "dfc446fe026d6ddd9c571fb042c9262739e7f942", "commit_rev": "7e00bda02eb5609bd5e2598f1a9e1e7271e96cdd"}
Message was sent while issue was closed.
Description was changed from ========== Hide supervised user creation from UserManager when force sign in is enabled. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Hide supervised user creation from UserManager when force sign in is enabled. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2561243002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Hide supervised user creation from UserManager when force sign in is enabled. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2561243002 ========== to ========== Hide supervised user creation from UserManager when force sign in is enabled. BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b74c0c839bc52d72add187ca55c0bf2eb60deaf8 Cr-Commit-Position: refs/heads/master@{#438194} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b74c0c839bc52d72add187ca55c0bf2eb60deaf8 Cr-Commit-Position: refs/heads/master@{#438194} |