Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2561203003: Introduce ServiceWorkerCache.Response.HasDeprecatedURL UMA (Closed)

Created:
4 years ago by horo
Modified:
4 years ago
Reviewers:
falken, rkaplow, nhiroki
CC:
chromium-reviews, asvitkine+watch_chromium.org, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, nhiroki
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ServiceWorkerCache.Response.HasDeprecatedURL UMA As falken's comment, this cl is splitted from https://codereview.chromium.org/2516353002. https://codereview.chromium.org/2516353002/diff/140001/content/browser/cache_storage/cache_storage_cache.cc#newcode1407 BUG=658249 Committed: https://crrev.com/1efb9a8a10ce04325dd43fd660ea2f748db2e0a2 Cr-Commit-Position: refs/heads/master@{#437558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/browser/cache_storage/cache_storage_cache.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
horo
falken@ Please review this.
4 years ago (2016-12-09 06:27:50 UTC) #2
falken
lgtm
4 years ago (2016-12-09 06:32:41 UTC) #5
horo
nhiroki@ Could you please review content/browser/cache_storage/cache_storage_cache.cc?
4 years ago (2016-12-09 06:34:45 UTC) #7
horo
rkaplow@ Could you please review tools/metrics/histograms/histograms.xml?
4 years ago (2016-12-09 06:35:37 UTC) #9
nhiroki
lgtm
4 years ago (2016-12-09 07:45:21 UTC) #12
rkaplow
lgtm
4 years ago (2016-12-09 15:58:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561203003/1
4 years ago (2016-12-09 16:23:12 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 16:30:32 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-09 16:32:13 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1efb9a8a10ce04325dd43fd660ea2f748db2e0a2
Cr-Commit-Position: refs/heads/master@{#437558}

Powered by Google App Engine
This is Rietveld 408576698