Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2561193003: [wasm][asm.js] Allow true/false in int binary ops. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Allow true/false in int binary ops. Because the parser optimizes !123 -> false, we allow booleans in expressions (but not parameter annotations). Allow this in asm-wasm-builder. Turn on an early out case in asm-typer that is fine. BUG=672784 R=titzer@chromium.org Committed: https://crrev.com/89e10055e484cbdba3facad75e8116076130fcc8 Cr-Commit-Position: refs/heads/master@{#41622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
bradnelson
4 years ago (2016-12-09 14:30:26 UTC) #3
titzer
On 2016/12/09 14:30:26, bradnelson wrote: lgtm
4 years ago (2016-12-09 14:50:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561193003/1
4 years ago (2016-12-09 14:59:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 15:01:09 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 15:01:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89e10055e484cbdba3facad75e8116076130fcc8
Cr-Commit-Position: refs/heads/master@{#41622}

Powered by Google App Engine
This is Rietveld 408576698