Revert "Disable local background equivalence when we have a box shadow due to painting bug."

Revert "Disable local background equivalence when we have a box shadow due to painting bug."

This reverts commit a12e7a002f85301bf013b45e6e8bb61455304a76.

BUG=646464
TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have
box shadows and the first box has sub-pixel AA text

Committed: https://crrev.com/c765a85995920f79d3132e06a2c146316b823c3f
Cr-Commit-Position: refs/heads/master@{#438020}

[smcgruer, 2016-12-08 20:11:56]

The CQ bit was checked by smcgruer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 20:12:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 21:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:46:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[smcgruer, 2016-12-12 23:10:21]

smcgruer@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[smcgruer, 2016-12-12 23:10:21]

I'm not quite sure about the LayoutTest failures. Seems to have something to do
with 'virtual' test suites, but it's unclear to me how to fix it. Suggestions
appreciated :)

[smcgruer, 2016-12-12 23:10:33]

The CQ bit was checked by smcgruer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 23:12:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-12 23:27:14]

On 2016/12/12 23:10:21, smcgruer wrote:
> I'm not quite sure about the LayoutTest failures. Seems to have something to
do
> with 'virtual' test suites, but it's unclear to me how to fix it. Suggestions
> appreciated :)

lgtm.

The change of text expectations look right. Now we paint background onto
scrolling contents layer for the test, making the layer opaque.

The virtual suite virtual/prefer_compositing_to_lcd_text forces
--enable-prefer-compositing-to-lcd-text, but the test should behave the same
running with or without virtual prefix because the flag is also forced in the
test.

Just examined the platform expectation files and found that the following files
are just the same as the base expectation:
third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrollbar-layer-placement-expected.txt
third_party/WebKit/LayoutTests/platform/mac-retina/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrollbar-layer-placement-expected.txt
third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrollbar-layer-placement-expected.txt

Please remove them in this CL. They might be left there by some sub-optimal
rebaselines.

The test doesn't run on Android and
third_party/WebKit/LayoutTests/platform/android/compositing/overflow/scrollbar-layer-placement-expected.txt
is out-dated. Please also remove it.

[smcgruer, 2016-12-12 23:33:05]

The CQ bit was checked by smcgruer@chromium.org

[smcgruer, 2016-12-12 23:33:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2561183002/#ps80001
(title: "Remove outdated expectation files as per reviewer comments")

[commit-bot: I haz the power, 2016-12-12 23:35:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:42:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-13 01:50:05]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:51:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:20:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481593805183820,
"parent_rev": "dac3154d076c9dd14fd12f811dd9af9b3ae3bfd2", "commit_rev":
"43f8af404e817f838848a39f6b13cc53aeeed6b5"}

[commit-bot: I haz the power, 2016-12-13 03:21:14]

Description was changed from

==========
Revert "Disable local background equivalence when we have a box shadow due to
painting bug."

This reverts commit a12e7a002f85301bf013b45e6e8bb61455304a76.

BUG=646464

TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have
box shadows and the first box has sub-pixel AA text
==========

to

==========
Revert "Disable local background equivalence when we have a box shadow due to
painting bug."

This reverts commit a12e7a002f85301bf013b45e6e8bb61455304a76.

BUG=646464

TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have
box shadows and the first box has sub-pixel AA text

Review-Url: https://codereview.chromium.org/2561183002
==========

[commit-bot: I haz the power, 2016-12-13 03:21:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-13 03:24:00]

Description was changed from

==========
Revert "Disable local background equivalence when we have a box shadow due to
painting bug."

This reverts commit a12e7a002f85301bf013b45e6e8bb61455304a76.

BUG=646464

TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have
box shadows and the first box has sub-pixel AA text

Review-Url: https://codereview.chromium.org/2561183002
==========

to

==========
Revert "Disable local background equivalence when we have a box shadow due to
painting bug."

This reverts commit a12e7a002f85301bf013b45e6e8bb61455304a76.

BUG=646464

TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have
box shadows and the first box has sub-pixel AA text

Committed: https://crrev.com/c765a85995920f79d3132e06a2c146316b823c3f
Cr-Commit-Position: refs/heads/master@{#438020}
==========

[commit-bot: I haz the power, 2016-12-13 03:24:00]

Patchset 5 (id:??) landed as
https://crrev.com/c765a85995920f79d3132e06a2c146316b823c3f
Cr-Commit-Position: refs/heads/master@{#438020}

[smcgruer, 2016-12-15 15:51:32]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2576423002/ by smcgruer@chromium.org.

The reason for reverting is: Caused a regression in drawing backgrounds when the
window was sized around 1280x1024. Regression seen in at least Windows and Linux
- see http://crbug.com/674429

BUG=674429.