Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2561173004: Cleanup RateCounter (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
Reviewers:
Lambros, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup RateCounter Previously RateCounter was using base::Time instead of base::TimeTicks, which may cause it to generate incorrect values in some cases. Fxed it to use TimeTicks. Also updated it to use TickClock interface for tests. Committed: https://crrev.com/fcfab00938f82a3830a9cf64eac4a5436f456250 Cr-Commit-Position: refs/heads/master@{#437712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -43 lines) Patch
M remoting/base/rate_counter.h View 3 chunks +9 lines, -9 lines 0 comments Download
M remoting/base/rate_counter.cc View 2 chunks +9 lines, -24 lines 0 comments Download
M remoting/base/rate_counter_unittest.cc View 5 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sergey Ulanov
4 years ago (2016-12-09 22:00:15 UTC) #2
Jamie
lgtm
4 years ago (2016-12-09 23:03:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561173004/1
4 years ago (2016-12-09 23:16:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-12-10 01:19:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561173004/1
4 years ago (2016-12-10 01:26:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 01:47:09 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 14:59:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcfab00938f82a3830a9cf64eac4a5436f456250
Cr-Commit-Position: refs/heads/master@{#437712}

Powered by Google App Engine
This is Rietveld 408576698