Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2561163004: [Mac] Delete the unused AvatarMenuBubbleController and its associated XIB. (Closed)

Created:
4 years ago by Robert Sesek
Modified:
4 years ago
Reviewers:
anthonyvd
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Delete the unused AvatarMenuBubbleController and its associated XIB. BUG=none R=anthonyvd@chromium.org Committed: https://crrev.com/d928ba63698af2bc0730baa9889bbdb1e7d9869e Cr-Commit-Position: refs/heads/master@{#437629}

Patch Set 1 #

Patch Set 2 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1229 lines) Patch
D chrome/app/nibs/AvatarMenuItem.xib View 1 chunk +0 lines, -79 lines 0 comments Download
M chrome/app/nibs/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.h View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.mm View 1 chunk +0 lines, -722 lines 0 comments Download
D chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm View 1 chunk +0 lines, -274 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Robert Sesek
4 years ago (2016-12-09 18:05:22 UTC) #5
anthonyvd
lgtm, yay for cleanup!
4 years ago (2016-12-09 18:12:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561163004/20001
4 years ago (2016-12-09 18:38:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 20:37:48 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 14:39:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d928ba63698af2bc0730baa9889bbdb1e7d9869e
Cr-Commit-Position: refs/heads/master@{#437629}

Powered by Google App Engine
This is Rietveld 408576698