Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2561133002: Moves include of objc_property_releaser out of a header. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
Reviewers:
jif
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves include of objc_property_releaser out of a header. Moves include of ojbc_property_releaser to the implementation file to allow this to be included from ARC code. Also moves ivars to the implementation file, per style guide. BUG=672510 TEST=None Committed: https://crrev.com/6f24b74e5e89616e42139a4e58d72848659caa1a Cr-Commit-Position: refs/heads/master@{#437575}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix_compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M ios/chrome/browser/snapshots/snapshot_cache.h View 2 chunks +1 line, -32 lines 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache.mm View 2 chunks +31 lines, -1 line 0 comments Download
M ios/chrome/browser/snapshots/snapshot_cache_unittest.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stkhapugin
PTAL
4 years ago (2016-12-09 16:30:20 UTC) #2
jif
lgtm
4 years ago (2016-12-09 16:33:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561133002/40001
4 years ago (2016-12-09 16:53:47 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 17:28:51 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 14:35:49 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f24b74e5e89616e42139a4e58d72848659caa1a
Cr-Commit-Position: refs/heads/master@{#437575}

Powered by Google App Engine
This is Rietveld 408576698