Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 256113003: Fix assertion when collecting stack trace from debug break. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix assertion when collecting stack trace from debug break. R=mstarzinger@chromium.org BUG=v8:3296 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21015

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : fix for the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M src/frames.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 7 months ago (2014-04-28 11:24:09 UTC) #1
Michael Starzinger
LGTM.
6 years, 7 months ago (2014-04-28 12:00:46 UTC) #2
Yang
6 years, 7 months ago (2014-04-28 12:08:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698