Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2561103004: [parser] Ensure asm.js modules always allocate context. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Ensure asm.js modules always allocate context. The deserialization of the {Scope::asm_module} predicate relies on a context being present for such modules. This ensures we always allocate such a context, even in cases where no variables are allocated in it. R=neis@chromium.org TEST=cctest/test-parsing/AsmModuleFlag BUG=v8:5653 Committed: https://crrev.com/5dcda5bb179a42a219022c8195ce7253d314db97 Cr-Commit-Position: refs/heads/master@{#41611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/ast/scopeinfo.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years ago (2016-12-09 09:27:40 UTC) #3
neis
lgtm
4 years ago (2016-12-09 09:33:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561103004/1
4 years ago (2016-12-09 10:10:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 10:12:16 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 10:12:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dcda5bb179a42a219022c8195ce7253d314db97
Cr-Commit-Position: refs/heads/master@{#41611}

Powered by Google App Engine
This is Rietveld 408576698