V4Only: In V4Only mode use PVer4 for all SafeBrowsing operations

chrome/browser/safe_browsing/services_delegate_impl.h

Index: chrome/browser/safe_browsing/services_delegate_impl.h
diff --git a/chrome/browser/safe_browsing/services_delegate_impl.h b/chrome/browser/safe_browsing/services_delegate_impl.h
index a6608f4c7bac05d94d9c757ebb6de54b86d2dfd6..e975b83914bcb5677d947af39b4d6151da87abf3 100644
--- a/chrome/browser/safe_browsing/services_delegate_impl.h
+++ b/chrome/browser/safe_browsing/services_delegate_impl.h
@@ -16,7 +16,7 @@
 
 namespace safe_browsing {
 
-class V4LocalDatabaseManager;
+class SafeBrowsingDatabaseManager;
 
 // Actual ServicesDelegate implementation. Create via
 // ServicesDelegate::Create().
@@ -28,7 +28,7 @@ class ServicesDelegateImpl : public ServicesDelegate {
 
  private:
   // ServicesDelegate:
-  const scoped_refptr<V4LocalDatabaseManager>& v4_local_database_manager()
+  const scoped_refptr<SafeBrowsingDatabaseManager>& v4_local_database_manager()

[Scott Hess - ex-Googler, 2016/12/08 06:02:55]

Wait - you can even do this?

I mean, of course you can, it compiles.  But I'm not even sure what it means.  I
guess that the implementation guarantees a value with storage to reference
(basically, it can only return a reference to a member variable or static)?

[Nathan Parker, 2016/12/08 23:00:58]

Yea it works, but constrains it as you describe. I think it'd be a bit clear to
use a non-ref version, but I'm trying to keep this CL small so it's easier to
merge.

       const override;
   void Initialize() override;
   void InitializeCsdService(
@@ -65,7 +65,7 @@ class ServicesDelegateImpl : public ServicesDelegate {
 
   // The Pver4 local database manager handles the database and download logic
   // Accessed on both UI and IO thread.
-  scoped_refptr<V4LocalDatabaseManager> v4_local_database_manager_;
+  scoped_refptr<SafeBrowsingDatabaseManager> v4_local_database_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(ServicesDelegateImpl);
 };