V4Only: In V4Only mode use PVer4 for all SafeBrowsing operations

chrome/browser/safe_browsing/services_delegate_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SERVICES_DELEGATE_IMPL_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SERVICES_DELEGATE_IMPL_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "chrome/browser/safe_browsing/client_side_detection_service.h"
 #include "chrome/browser/safe_browsing/download_protection_service.h"
 #include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"
 #include "chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h"
 #include "chrome/browser/safe_browsing/services_delegate.h"
 
 namespace safe_browsing {
 
-class V4LocalDatabaseManager;
+class SafeBrowsingDatabaseManager;
 
 // Actual ServicesDelegate implementation. Create via
 // ServicesDelegate::Create().
 class ServicesDelegateImpl : public ServicesDelegate {
  public:
   ServicesDelegateImpl(SafeBrowsingService* safe_browsing_service,
                        ServicesDelegate::ServicesCreator* services_creator);
   ~ServicesDelegateImpl() override;
 
  private:
   // ServicesDelegate:
-  const scoped_refptr<V4LocalDatabaseManager>& v4_local_database_manager()
+  const scoped_refptr<SafeBrowsingDatabaseManager>& v4_local_database_manager()

[Scott Hess - ex-Googler, 2016/12/08 06:02:55]

Wait - you can even do this?

I mean, of course you can, it compiles.  But I'm not even sure what it means.  I
guess that the implementation guarantees a value with storage to reference
(basically, it can only return a reference to a member variable or static)?

[Nathan Parker, 2016/12/08 23:00:58]

Yea it works, but constrains it as you describe. I think it'd be a bit clear to
use a non-ref version, but I'm trying to keep this CL small so it's easier to
merge.

       const override;
   void Initialize() override;
   void InitializeCsdService(
       net::URLRequestContextGetter* context_getter) override;
   void ShutdownServices() override;
   void RefreshState(bool enable) override;
   void ProcessResourceRequest(const ResourceRequestInfo* request) override;
   std::unique_ptr<TrackedPreferenceValidationDelegate>
       CreatePreferenceValidationDelegate(Profile* profile) override;
   void RegisterDelayedAnalysisCallback(
@@ skipping 16 matching lines @@
   std::unique_ptr<ClientSideDetectionService> csd_service_;
   std::unique_ptr<DownloadProtectionService> download_service_;
   std::unique_ptr<IncidentReportingService> incident_service_;
   std::unique_ptr<ResourceRequestDetector> resource_request_detector_;
 
   SafeBrowsingService* const safe_browsing_service_;
   ServicesDelegate::ServicesCreator* const services_creator_;
 
   // The Pver4 local database manager handles the database and download logic
   // Accessed on both UI and IO thread.
-  scoped_refptr<V4LocalDatabaseManager> v4_local_database_manager_;
+  scoped_refptr<SafeBrowsingDatabaseManager> v4_local_database_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(ServicesDelegateImpl);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SERVICES_DELEGATE_IMPL_H_