Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2560993003: Fix the parsing of colors used as canvas styles to ignore whitespace (Closed)

Created:
4 years ago by Justin Novosad
Modified:
4 years ago
Reviewers:
xidachen
CC:
chromium-reviews, blink-reviews-style_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, Justin Novosad, haraken, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the parsing of colors used as canvas styles to ignore whitespace BUG=668584 Committed: https://crrev.com/759bba67481eed3cde4d6de8f95854dea1c1f81e Cr-Commit-Position: refs/heads/master@{#437710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/canvas/canvas-whitespace-parsing.html View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Justin Novosad
PTAL
4 years ago (2016-12-08 20:27:08 UTC) #3
xidachen
lgtm
4 years ago (2016-12-08 21:39:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560993003/1
4 years ago (2016-12-09 19:49:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 01:36:23 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 14:59:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/759bba67481eed3cde4d6de8f95854dea1c1f81e
Cr-Commit-Position: refs/heads/master@{#437710}

Powered by Google App Engine
This is Rietveld 408576698