Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2560953004: Improve documentation of the targets generated by mojom.gni. (Closed)

Created:
4 years ago by Reilly Grant (use Gerrit)
Modified:
4 years ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve documentation of the targets generated by mojom.gni. This calls out the targets generated by mojom.gni that other targets should be depending on. BUG=None Committed: https://crrev.com/3d2ecd2ded80d8fd726504a48b3b80d6df6c00d2 Cr-Commit-Position: refs/heads/master@{#437609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M mojo/public/tools/bindings/mojom.gni View 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Reilly Grant (use Gerrit)
Please take a look. This will hopefully answer questions I've gotten about how to use ...
4 years ago (2016-12-09 01:51:46 UTC) #4
yzshen1
Thanks! LGTM
4 years ago (2016-12-09 18:58:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560953004/1
4 years ago (2016-12-09 18:59:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 19:47:18 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d2ecd2ded80d8fd726504a48b3b80d6df6c00d2
Cr-Commit-Position: refs/heads/master@{#437609}

Powered by Google App Engine
This is Rietveld 408576698