Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2560913002: Revert "Floating legend should be added to the fieldset's anonymous block." (Closed)

Created:
4 years ago by Gleb Lanbin
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert "Floating legend should be added to the fieldset's anonymous block." This reverts commit 0f77a4ef8c0218492b5b8689a793b34b0f5a34d8. Reason for revert: broke real world websites BUG=670837 Review-Url: https://codereview.chromium.org/2552373002 Cr-Commit-Position: refs/heads/master@{#436729} (cherry picked from commit f7ec97aa2c8a33bef125c9fa0f08802d2ab12c5c) Committed: https://chromium.googlesource.com/chromium/src/+/e319e60474b1842ed11653ffe4b5d443a21ebac5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -50 lines) Patch
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 2 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Gleb Lanbin
4 years ago (2016-12-07 18:51:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e319e60474b1842ed11653ffe4b5d443a21ebac5.

Powered by Google App Engine
This is Rietveld 408576698