Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2552373002: Revert "Floating legend should be added to the fieldset's anonymous block." (Closed)

Created:
4 years ago by Gleb Lanbin
Modified:
4 years ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Floating legend should be added to the fieldset's anonymous block." This reverts commit 0f77a4ef8c0218492b5b8689a793b34b0f5a34d8. Reason for revert: broke real world websites BUG=670837 Committed: https://crrev.com/f7ec97aa2c8a33bef125c9fa0f08802d2ab12c5c Cr-Commit-Position: refs/heads/master@{#436729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -50 lines) Patch
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 2 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Gleb Lanbin
4 years ago (2016-12-06 18:57:45 UTC) #2
cbiesinger
lgtm
4 years ago (2016-12-06 19:03:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552373002/20001
4 years ago (2016-12-06 20:40:38 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-06 21:19:05 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-06 21:21:57 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7ec97aa2c8a33bef125c9fa0f08802d2ab12c5c
Cr-Commit-Position: refs/heads/master@{#436729}

Powered by Google App Engine
This is Rietveld 408576698