Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Issue 2560873004: ServiceWorker: add crash keys for debugging of IPCs and remove old keys (Closed)

Created:
4 years ago by shimazu
Modified:
4 years ago
Reviewers:
falken, jam
CC:
chromium-reviews, sadrul, tzik, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kinuko+watch, shaktisahu+watch-blimp_chromium.org, jsbell+serviceworker_chromium.org, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, lcwu+watch_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, kalyank, scf+watch-blimp_chromium.org, blink-worker-reviews_chromium.org, lethalantidote+watch-blimp_chromium.org, nhiroki, alokp+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, michaeln, shimazu+serviceworker_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, serviceworker-reviews, steimel+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: add crash keys for debugging of IPCs and remove old keys This patch is to check if the process_id() is kInvalidUniqueID or the value itself is valid. Additionally, I removed several crash keys which was for an issue which has been fixed. BUG=668633, 619294 Committed: https://crrev.com/7194546a50bbbc4c39425825459fea8f14805f99 Cr-Commit-Position: refs/heads/master@{#437432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M blimp/engine/app/blimp_engine_crash_keys.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chromecast/crash/cast_crash_keys.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
shimazu
ptal
4 years ago (2016-12-08 07:15:42 UTC) #4
falken
lgtm
4 years ago (2016-12-08 07:33:02 UTC) #5
shimazu
jam@chromium.org: Please review changes in crash_keys.cc and chrome_crash_reporter_client_win.cc
4 years ago (2016-12-08 07:48:41 UTC) #7
jam
lgtm
4 years ago (2016-12-08 17:03:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560873004/1
4 years ago (2016-12-09 01:53:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 02:18:16 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-09 02:22:54 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7194546a50bbbc4c39425825459fea8f14805f99
Cr-Commit-Position: refs/heads/master@{#437432}

Powered by Google App Engine
This is Rietveld 408576698