Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2560873004: ServiceWorker: add crash keys for debugging of IPCs and remove old keys (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 {"postmessage_script_info", kLargeSize}, 190 {"postmessage_script_info", kLargeSize},
191 191
192 // Temporary for https://crbug.com/616149. 192 // Temporary for https://crbug.com/616149.
193 {"existing_extension_pref_value_type", crash_keys::kSmallSize}, 193 {"existing_extension_pref_value_type", crash_keys::kSmallSize},
194 194
195 // Temporary for https://crbug.com/630495. 195 // Temporary for https://crbug.com/630495.
196 {"swdh_register_cannot_host_url", crash_keys::kLargeSize}, 196 {"swdh_register_cannot_host_url", crash_keys::kLargeSize},
197 {"swdh_register_cannot_scope_url", crash_keys::kLargeSize}, 197 {"swdh_register_cannot_scope_url", crash_keys::kLargeSize},
198 {"swdh_register_cannot_script_url", crash_keys::kLargeSize}, 198 {"swdh_register_cannot_script_url", crash_keys::kLargeSize},
199 199
200 // Temporary for https://crbug.com/619294.
201 {"swdh_unregister_cannot_host_url", crash_keys::kLargeSize},
202 {"swdh_unregister_cannot_scope_url", crash_keys::kLargeSize},
203
204 // Temporary for https://crbug.com/630496. 200 // Temporary for https://crbug.com/630496.
205 {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize}, 201 {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize},
206 {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize}, 202 {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize},
203
204 // Temporary for https://crbug.com/668633.
205 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize},
206 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize},
207 }; 207 };
208 208
209 // This dynamic set of keys is used for sets of key value pairs when gathering 209 // This dynamic set of keys is used for sets of key value pairs when gathering
210 // a collection of data, like command line switches or extension IDs. 210 // a collection of data, like command line switches or extension IDs.
211 std::vector<base::debug::CrashKey> keys(fixed_keys, 211 std::vector<base::debug::CrashKey> keys(fixed_keys,
212 fixed_keys + arraysize(fixed_keys)); 212 fixed_keys + arraysize(fixed_keys));
213 213
214 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 214 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
215 215
216 // Register the extension IDs. 216 // Register the extension IDs.
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 402 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
403 return install_static::GetCollectStatsInSample(); 403 return install_static::GetCollectStatsInSample();
404 } 404 }
405 405
406 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 406 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
407 const std::string& process_type) { 407 const std::string& process_type) {
408 // This is not used by Crashpad (at least on Windows). 408 // This is not used by Crashpad (at least on Windows).
409 NOTREACHED(); 409 NOTREACHED();
410 return true; 410 return true;
411 } 411 }
OLDNEW
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698