Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2560823005:
Do not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown (Closed)
DescriptionDo not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown
BUG=672593
Committed: https://crrev.com/97430eb75aa5d976e9c02c2cf5ca4caf7d13513d
Cr-Commit-Position: refs/heads/master@{#437743}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix trybot #Messages
Total messages: 22 (13 generated)
The CQ bit was checked by jianli@chromium.org to run a CQ dry run
jianli@chromium.org changed reviewers: + mmenke@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
LGTM
fgorski@chromium.org changed reviewers: + fgorski@chromium.org
https://codereview.chromium.org/2560823005/diff/1/components/error_page/commo... File components/error_page/common/localized_error.cc (right): https://codereview.chromium.org/2560823005/diff/1/components/error_page/commo... components/error_page/common/localized_error.cc:1029: failed_url.is_valid() && failed_url.SchemeIsHTTPOrHTTPS() && is it possible to use OfflinePageModel::CanSaveURL here?
I try to avoid using it to avoid dep. We may refactor our code in the future to address this if we need more complicated logic. But for now I think this is good enough. On Fri, Dec 9, 2016 at 10:09 AM, <fgorski@chromium.org> wrote: > > https://codereview.chromium.org/2560823005/diff/1/ > components/error_page/common/localized_error.cc > File components/error_page/common/localized_error.cc (right): > > https://codereview.chromium.org/2560823005/diff/1/ > components/error_page/common/localized_error.cc#newcode1029 > components/error_page/common/localized_error.cc:1029: > failed_url.is_valid() && failed_url.SchemeIsHTTPOrHTTPS() && > is it possible to use OfflinePageModel::CanSaveURL here? > > https://codereview.chromium.org/2560823005/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by jianli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by jianli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org Link to the patchset: https://codereview.chromium.org/2560823005/#ps20001 (title: "Fix trybot")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481335309201180,
"parent_rev": "5b52b93aa7f9f0cb59ff0ae06e24e2415ee8de04", "commit_rev":
"857fe9d386dc210f70682cd82f60a76f828612d6"}
Message was sent while issue was closed.
Description was changed from ========== Do not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown BUG=672593 ========== to ========== Do not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown BUG=672593 Review-Url: https://codereview.chromium.org/2560823005 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Do not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown BUG=672593 Review-Url: https://codereview.chromium.org/2560823005 ========== to ========== Do not show "DOWNLOAD PAGE LATER" button if RELOAD button is shown BUG=672593 Committed: https://crrev.com/97430eb75aa5d976e9c02c2cf5ca4caf7d13513d Cr-Commit-Position: refs/heads/master@{#437743} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/97430eb75aa5d976e9c02c2cf5ca4caf7d13513d Cr-Commit-Position: refs/heads/master@{#437743} |
