Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 2560823003: Avoid WTF::Vector::at() and operator[] in core/xml. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
hayato
CC:
blink-reviews, chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid WTF::Vector::at() and operator[] in core/xml. at() and operator[] are slow due to RELEASE_ASSERT. We can avoid the slowness by range-based |for|. This CL has no behavior changes except runtime performance. BUG=668300 Committed: https://crrev.com/c02417a9281de18ce956313d8b893a328c85f605 Cr-Commit-Position: refs/heads/master@{#437202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -53 lines) Patch
M third_party/WebKit/Source/core/xml/XPathFunctions.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathNodeSet.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathPath.cpp View 3 chunks +7 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathPredicate.cpp View 5 chunks +14 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.cpp View 4 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
hayato@, would you review this please?
4 years ago (2016-12-08 03:07:01 UTC) #6
hayato
lgtm
4 years ago (2016-12-08 06:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560823003/1
4 years ago (2016-12-08 07:03:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 07:09:00 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 07:11:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c02417a9281de18ce956313d8b893a328c85f605
Cr-Commit-Position: refs/heads/master@{#437202}

Powered by Google App Engine
This is Rietveld 408576698