Avoid WTF::Vector::at() and operator[] in core/xml.

third_party/WebKit/Source/core/xml/XPathFunctions.cpp

 /*
  * Copyright (C) 2005 Frerich Raabe <raabe@kde.org>
  * Copyright (C) 2006, 2009 Apple Inc.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 316 matching lines @@
 
 Value FunPosition::evaluate(EvaluationContext& context) const {
   return context.position;
 }
 
 Value FunId::evaluate(EvaluationContext& context) const {
   Value a = arg(0)->evaluate(context);
   StringBuilder idList;  // A whitespace-separated list of IDs
 
   if (a.isNodeSet()) {
-    const NodeSet& nodes = a.toNodeSet(&context);
-    for (size_t i = 0; i < nodes.size(); ++i) {
-      String str = stringValue(nodes[i]);
-      idList.append(str);
+    for (const auto& node : a.toNodeSet(&context)) {
+      idList.append(stringValue(node));
       idList.append(' ');
     }
   } else {
-    String str = a.toString();
-    idList.append(str);
+    idList.append(a.toString());
   }
 
   TreeScope& contextScope = context.node->treeScope();
   NodeSet* result(NodeSet::create());
   HeapHashSet<Member<Node>> resultSet;
 
   unsigned startPos = 0;
   unsigned length = idList.length();
   while (true) {
     while (startPos < length && isWhitespace(idList[startPos]))
@@ skipping 314 matching lines @@
   Value a = arg(0)->evaluate(context);
   if (!a.isNodeSet())
     return 0.0;
 
   double sum = 0.0;
   const NodeSet& nodes = a.toNodeSet(&context);
   // To be really compliant, we should sort the node-set, as floating point
   // addition is not associative.  However, this is unlikely to ever become a
   // practical issue, and sorting is slow.
 
-  for (unsigned i = 0; i < nodes.size(); i++)
-    sum += Value(stringValue(nodes[i])).toNumber();
+  for (const auto& node : nodes)
+    sum += Value(stringValue(node)).toNumber();
 
   return sum;
 }
 
 Value FunFloor::evaluate(EvaluationContext& context) const {
   return floor(arg(0)->evaluate(context).toNumber());
 }
 
 Value FunCeiling::evaluate(EvaluationContext& context) const {
   return ceil(arg(0)->evaluate(context).toNumber());
@@ skipping 74 matching lines @@
     return nullptr;
 
   Function* function = functionRec->factoryFn();
   function->setArguments(args);
   function->setName(name);
   return function;
 }
 
 }  // namespace XPath
 }  // namespace blink