Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 25607007: Fix ImmersiveModeControllerAshTestWithBrowserView.Layout (Closed)

Created:
7 years, 2 months ago by pkotwicz
Modified:
7 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Fix ImmersiveModeControllerAshTestWithBrowserView.Layout BUG=302908 TEST=ImmersiveModeControllerAshTestWithBrowserView.Layout is not flaky anymore Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226838

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
James, can you please take a look? The test flakiness is because the mouse can ...
7 years, 2 months ago (2013-10-03 00:36:27 UTC) #1
James Cook
lgtm
7 years, 2 months ago (2013-10-03 16:45:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/25607007/5001
7 years, 2 months ago (2013-10-03 17:03:21 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 20:45:46 UTC) #4
Message was sent while issue was closed.
Change committed as 226838

Powered by Google App Engine
This is Rietveld 408576698