Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

Issue 25607007: Fix ImmersiveModeControllerAshTestWithBrowserView.Layout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/unit_tests.gtest.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
index 955d7c01fba6d0aa52345ca62fa6e6d7bd10a008..c09c9e13470469f86951ea30eafc811a03d7cdb9 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
@@ -108,6 +108,9 @@ class ImmersiveModeControllerAshTest : public ash::test::AshTestBase {
controller_->Init(delegate_.get(), widget_, top_container_);
SetAnimationsDisabled(true);
+
+ // The mouse is moved so that it is not over |top_container_| by
+ // AshTestBase.
}
// Enable or disable the immersive mode controller's animations. When the
@@ -806,6 +809,13 @@ class ImmersiveModeControllerAshTestWithBrowserView
controller_ = static_cast<ImmersiveModeControllerAsh*>(
browser_view()->immersive_mode_controller());
controller_->DisableAnimationsForTest();
+
+ // Move the mouse so that it is not over the top-of-window views. The mouse
+ // position matters because entering immersive fullscreen causes synthesized
+ // mouse moves. (If the mouse is at the very top of the screen when entering
+ // immersive fullscreen, the top-of-window views will hide, then reveal as
+ // a result of the synthesized mouse moves).
+ controller()->SetMouseHoveredForTest(false);
}
// Returns the bounds of |view| in widget coordinates.
@@ -824,8 +834,7 @@ class ImmersiveModeControllerAshTestWithBrowserView
// Test the layout and visibility of the tabstrip, toolbar and TopContainerView
// in immersive fullscreen.
-// Flaky. See http://crbug.com/302908 .
-TEST_F(ImmersiveModeControllerAshTestWithBrowserView, DISABLED_Layout) {
+TEST_F(ImmersiveModeControllerAshTestWithBrowserView, Layout) {
AddTab(browser(), GURL("about:blank"));
TabStrip* tabstrip = browser_view()->tabstrip();
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/unit_tests.gtest.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698