Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2560593002: Make HttpNetworkSession::DumpMemoryStats attribute memory usage correctly (Closed)

Created:
4 years ago by xunjieli
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL creates an empty MemoryAllocatorDump under URLRequestContext so AddOwnershipEdge can attribute memory correctly between URLRequestContexts. See the following doc for more details on why it is needed. https://docs.google.com/document/d/1-dmr_dVgO090Y5_3K9itjsE0MsBTmbqwovu6lup1i14/edit BUG=669108 Committed: https://crrev.com/2a2468bdec640adaa6a08f9ca1cfe465e56e7600 Cr-Commit-Position: refs/heads/master@{#441466}

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M net/http/http_network_session.cc View 1 chunk +12 lines, -15 lines 0 comments Download
M net/url_request/url_request_context_unittest.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
xunjieli
This is to follow up on the discussion at https://docs.google.com/document/d/1-dmr_dVgO090Y5_3K9itjsE0MsBTmbqwovu6lup1i14/edit. I found that the aliasing ...
4 years ago (2016-12-15 19:05:36 UTC) #6
xunjieli
Primiano, Sid: A friendly ping!
3 years, 11 months ago (2017-01-03 00:44:41 UTC) #12
xunjieli
On 2017/01/03 00:44:41, xunjieli wrote: > Primiano, Sid: A friendly ping! A friendly ping! (I ...
3 years, 11 months ago (2017-01-04 18:49:14 UTC) #13
ssid
lgtm thanks
3 years, 11 months ago (2017-01-04 20:08:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560593002/60001
3 years, 11 months ago (2017-01-04 20:09:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
3 years, 11 months ago (2017-01-04 21:18:58 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 21:21:32 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a2468bdec640adaa6a08f9ca1cfe465e56e7600
Cr-Commit-Position: refs/heads/master@{#441466}

Powered by Google App Engine
This is Rietveld 408576698