Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Issue 2560583002: Strings related to the shipping address in payment summary view and address selection view. (Closed)

Created:
4 years ago by Moe
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strings related to the shipping address in payment summary view and address selection view. Also renames payment_address to shipping address in PaymentRequest to match the specs BUG=602666 Committed: https://crrev.com/5fe2c203f45aeb35bfefa3febbc7baed5edc350b Cr-Commit-Position: refs/heads/master@{#437528}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by jdonnelly@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ios/web/payments/payment_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/payments/payment_request_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/public/payments/payment_request.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
Moe
Hi, Please review this CL.
4 years ago (2016-12-06 20:30:33 UTC) #4
Justin Donnelly
lgtm mod minor comment fixes https://codereview.chromium.org/2560583002/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2560583002/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode957 ios/chrome/app/strings/ios_strings.grd:957: <message name="IDS_IOS_PAYMENT_REQUEST_SHIPPING_ADDRESS_SELECTION_ADD_BUTTON" desc="Label of ...
4 years ago (2016-12-07 18:18:23 UTC) #7
Moe
Thank you. https://codereview.chromium.org/2560583002/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2560583002/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode957 ios/chrome/app/strings/ios_strings.grd:957: <message name="IDS_IOS_PAYMENT_REQUEST_SHIPPING_ADDRESS_SELECTION_ADD_BUTTON" desc="Label of the button to ...
4 years ago (2016-12-08 20:13:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560583002/20001
4 years ago (2016-12-08 20:14:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/321827)
4 years ago (2016-12-08 20:58:53 UTC) #15
Moe
marq@ tbr
4 years ago (2016-12-08 21:37:04 UTC) #17
marq (ping after 24h)
lgtm
4 years ago (2016-12-09 11:53:37 UTC) #18
Moe
On 2016/12/09 11:53:37, marq wrote: > lgtm Thanks.
4 years ago (2016-12-09 13:54:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560583002/20001
4 years ago (2016-12-09 13:54:15 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 13:58:22 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-09 13:59:58 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fe2c203f45aeb35bfefa3febbc7baed5edc350b
Cr-Commit-Position: refs/heads/master@{#437528}

Powered by Google App Engine
This is Rietveld 408576698