Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2560553004: Revert of [DevTools] Remove methods on Common.Event. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, Eric Willigers, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Remove methods on Common.Event. (patchset #2 id:20001 of https://codereview.chromium.org/2553043003/ ) Reason for revert: Broke toolbar buttons. See issue 671936, 672020, 671984. Original issue's description: > [DevTools] Remove methods on Common.Event. > > Patch removes preventDefault(), stopPropagation(), consume() and .type property. > This is a preparation for typed events, which will not inherit from Common.Event. > > BUG=none > > Committed: https://crrev.com/ded3e43b7d536317c1041725ff41dcb15177d8fc > Cr-Commit-Position: refs/heads/master@{#436788} TBR=lushnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/cd6bd661a2011522601c8aeef55775a823dd934a Cr-Commit-Position: refs/heads/master@{#437031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -261 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/font-face.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/font-face-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-test.js View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 7 chunks +17 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Object.js View 3 chunks +33 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DockController.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Spectrum.js View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 7 chunks +11 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layer_viewer/TransformController.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 4 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js View 4 chunks +5 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 4 chunks +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js View 3 chunks +5 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 2 chunks +8 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 2 chunks +16 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 5 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 2 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js View 4 chunks +3 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dgozman
Created Revert of [DevTools] Remove methods on Common.Event.
4 years ago (2016-12-07 19:29:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560553004/1
4 years ago (2016-12-07 19:29:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 19:31:47 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-07 19:34:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd6bd661a2011522601c8aeef55775a823dd934a
Cr-Commit-Position: refs/heads/master@{#437031}

Powered by Google App Engine
This is Rietveld 408576698