third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js - Issue 2560553004: Revert of [DevTools] Remove methods on Common.Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2560553004: Revert of [DevTools] Remove methods on Common.Event. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

index d21e64411a579118adf8c898517d6dcf3d3b6518..69b130be8540cce69437fc62a31fef6fcc7dccf3 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

@@ -16,7 +16,7 @@

this._breakpointElements = new Map();

this._addButton = new UI.ToolbarButton(Common.UIString('Add breakpoint'), 'largeicon-add');

- this._addButton.addEventListener(UI.ToolbarButton.Events.Click, this._addButtonClicked.bind(this));

+ this._addButton.addEventListener('click', this._addButtonClicked.bind(this));

this.emptyElement.addEventListener('contextmenu', this._emptyElementContextMenu.bind(this), true);

SDK.targetManager.observeTargets(this, SDK.Target.Capability.Browser);

@@ -52,7 +52,10 @@

contextMenu.show();

}

- _addButtonClicked() {

+ _addButtonClicked(event) {

+ if (event)

+ event.consume();

UI.viewManager.showView('sources.xhrBreakpoints');

var inputElementContainer = createElementWithClass('p', 'breakpoint-condition');